Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Client user code deployment regression #15006

Merged

Conversation

@sancar
Copy link
Member

sancar commented May 9, 2019

The regression caused by the fix of the following issue
#4641
Related fix
#13887
And we added an assert so that we do not do a remote operation
in generic client threads in the future.
#14643

In this pr, we are not using the unblockable thread factory so that
the assert will not fail when user code deployment is enabled.
Also we are increasing the pool size only when user code
deployment is enabled.
fixes #15004

@sancar sancar added this to the 4.0 milestone May 9, 2019
@sancar sancar self-assigned this May 9, 2019
@sancar sancar force-pushed the sancar:fix/usercodedeploymentRegression/master branch 3 times, most recently from 17b26fb to 45c3767 May 10, 2019
@mdogan
mdogan approved these changes May 10, 2019
The regression caused by the fix of the following issue
#4641
Related fix
#13887
And we added an assert so that we do not do a remote operation
in generic client threads in the future.
#14643

In this pr, we are not using the unblockable thread factory so that
the assert will not fail when user code deployment is enabled.
Also we are increasing the pool size only when user code
deployment is enabled.
fixes #15004
@sancar sancar force-pushed the sancar:fix/usercodedeploymentRegression/master branch from 45c3767 to 2d7ebf8 May 10, 2019
@sancar sancar merged commit 7c19f2c into hazelcast:master May 10, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@sancar sancar deleted the sancar:fix/usercodedeploymentRegression/master branch May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.