Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for HazelcastJsonValue over Rest #15017

Merged
merged 1 commit into from May 15, 2019

Conversation

@mustafaiman
Copy link
Contributor

mustafaiman commented May 10, 2019

When a HazelcastJsonValue is requested over Rest API, we return UTF8 encoded json value. Response has the json string in payload and "Content-Type" header is set to application/json. This is a very small change. Rest of the PR is about refactoring to test classes.

When a HazelcastJsonValue is requested over Rest API, we return UTF8 encoded json value. Response has the json string in payload and "Content-Type" header is set to application/json. This is a very small change. Rest of the PR is about refactoring to test classes.
@mustafaiman mustafaiman added this to the 4.0 milestone May 10, 2019
@mustafaiman mustafaiman marked this pull request as ready for review May 10, 2019
@mustafaiman

This comment has been minimized.

Copy link
Contributor Author

mustafaiman commented May 10, 2019

run-lab-run

Copy link
Contributor

vojtechtoman left a comment

Looks good to me.

Copy link
Contributor

galibey left a comment

Looks good 👍

@mustafaiman

This comment has been minimized.

Copy link
Contributor Author

mustafaiman commented May 15, 2019

Thanks for the reviews!

@mustafaiman mustafaiman merged commit caa36fb into hazelcast:master May 15, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mustafaiman mustafaiman deleted the mustafaiman:json-over-rest branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.