Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes internal listener leak #15041

Merged
merged 1 commit into from May 16, 2019

Conversation

@sancar
Copy link
Member

sancar commented May 15, 2019

We have two listeners that are not registered via
ClientListenerService.registerListener because they are on single
connection, and they are not cluster wide listeners.

Cleanups of event handlers of these listeners were missing and added
in this pr.

fixes #15034

We have two listeners that are not registered via
ClientListenerService.registerListener because they are on single
connection, and they are not cluster wide listeners.

Cleanups of event handlers of these listeners were missing and added
in this pr.

fixes #15034
@sancar sancar added this to the 4.0 milestone May 15, 2019
@sancar sancar self-assigned this May 15, 2019
@sancar sancar requested review from ihsandemir and asimarslan May 15, 2019
@@ -374,6 +374,7 @@ public void run() {

setOwnerConnectionAddress(null);
connectionStrategy.onDisconnectFromCluster();
client.onClusterDisconnect();

This comment has been minimized.

Copy link
@ihsandemir

ihsandemir May 15, 2019

Contributor

previous line uses method naming as onDisconnectFromCluster and yet the new introduced method at this line is named onDisconnectFromCluster . I just wish that they are consistent and the same naming.

This comment has been minimized.

Copy link
@sancar

sancar May 16, 2019

Author Member

This is meant to be consistent with client.onClusterConnect

@sancar

This comment has been minimized.

Copy link
Member Author

sancar commented May 16, 2019

run-lab-run

@sancar

This comment has been minimized.

Copy link
Member Author

sancar commented May 16, 2019

run-lab-run

@sancar sancar merged commit 1be5c23 into hazelcast:master May 16, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@sancar sancar deleted the sancar:fix/internalListenerLeak/master branch May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.