Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Add client full example configuration files #15056

Merged
merged 4 commits into from May 28, 2019

Conversation

@blazember
Copy link
Contributor

blazember commented May 17, 2019

There were hazelcast-client-full.[xml|yaml] configuration files shipped with the hazelcast-client.jar. These files however had no comments, and the files were used by tests too. To make test files and full example configs separated, these files are moved to the test scope, but also used as a basis for the full example config files that are extended with explanatory comments. Client failover full example configs are added too.

Besides this, the client failover config XSDs got fixed. These fixes include:

  • Defining target namespace
  • Change the <try-count> element's type from xs:int to non-space-string otherwise schema validation error is thrown if the variable replacer is used to configure the try count value.

The 3.12 client failover XSD is changed retrospectively, but without the fix, schema validation fails. This needs further coordination to update the XSD.

  • Backported to 3.12.1

Implements #14948

4.0 EE PR: hazelcast/hazelcast-enterprise#2991

3.12.1 OSS PR: #15057

blazember added 2 commits May 17, 2019
There were `hazelcast-client-full.[xml|yaml]` configuration files
shipped with the `hazelcast-client.jar`. These files however had no
comments, and the files were used by tests too. To make test files and
full example configs separated, these files are moved to the test scope,
but also used as a basis for the full example config files that are
extended with explanatory comments. Client failover full example configs
are added too.

Besides this, the client failover config XSDs got fixed. These fixes
include:
- Defining target namespace
- Change the <try-count> element's type from "xs:int" to
"non-space-string" otherwise schema validation error is thrown if the
variable replacer is used to configure the try count value.

The 3.12 XSD is changed retrospectively, but without the fix, schema
validation fails if used. This needs further coordination to update
the XSD.

Implements #14948
@blazember blazember force-pushed the blazember:4.0/client-full-example-configs branch from a6f7b45 to 7e9e4ca May 23, 2019
@sancar
sancar approved these changes May 24, 2019
@blazember blazember force-pushed the blazember:4.0/client-full-example-configs branch from 3a904d0 to 8fda75a May 24, 2019
@blazember blazember requested a review from asimarslan May 24, 2019
@sancar
sancar approved these changes May 24, 2019
@blazember

This comment has been minimized.

Copy link
Contributor Author

blazember commented May 27, 2019

run-lab-run

@blazember blazember merged commit bbda865 into hazelcast:master May 28, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@blazember blazember deleted the blazember:4.0/client-full-example-configs branch May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.