Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames IdentifiedDataSerializable#getId to getClassId #15127

Merged

Conversation

@mustafaiman
Copy link
Contributor

mustafaiman commented Jun 3, 2019

All changes are by automatic refactoring of IntelliJ Idea. Only hand-made change is in MetadataRaftGroupManager line 403. I think getId() was used instead of id() by mistake there. I corrected it by hand. There, id() method can be renamed to getId() in another PR. I guess it was named as id() due to IDS name clash which is now fixed.

I ran copies of Hazelcast-3.x-OracleJDK8 and Hazelcast-EE-3.x-OracleJDK8 with the changes. Both builds passed.

http://jenkins.hazelcast.com/job/Mustafa-3.x-OracleJDK8-clone/ (one unrelated MapLock failure)
http://jenkins.hazelcast.com/job/Mustafa-EE-3.x-OracleJDK8-clone/

EE: hazelcast/hazelcast-enterprise#3017
Fixes: #1677

All changes are by automatic refactoring of IntelliJ Idea. Only hand-made change is in MetadataRaftGroupManager line 403. I think `getId()` was used instead of `id()` by mistake there. I corrected it by hand. There, `id()` method can be renamed to `getId()` in another PR. I guess it was named as `id()` due to IDS name clash which is now fixed.
@pveentjer

This comment has been minimized.

Copy link
Member

pveentjer commented Jun 4, 2019

I guess there also is an EE pr?

@mmedenjak

This comment has been minimized.

Copy link
Contributor

mmedenjak commented Jun 4, 2019

@mustafaiman mustafaiman merged commit c465bf5 into hazelcast:master Jun 4, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mustafaiman mustafaiman deleted the mustafaiman:cleanup/serializable-interfaces branch Jun 4, 2019
mustafaiman added a commit to mustafaiman/hazelcast-reference-manual that referenced this pull request Jun 11, 2019
This change was introduced in hazelcast/hazelcast#15127. Reference manual is fixed to conform the name change.
mustafaiman added a commit to mustafaiman/hazelcast-reference-manual that referenced this pull request Jun 11, 2019
This change was introduced in hazelcast/hazelcast#15127. Reference manual is fixed to conform the name change.
mustafaiman added a commit to mustafaiman/hazelcast-reference-manual that referenced this pull request Jun 11, 2019
This change was introduced in hazelcast/hazelcast#15127. Reference manual is fixed to conform the name change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.