Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifies InvalidConfigurationException and ConfigurationException #15132

Conversation

@mustafaiman
Copy link
Contributor

mustafaiman commented Jun 5, 2019

These two are used interchangibly across the codebase. There is no point in having both of them. Also LegacyMatchingPointConfigPatternMatcher and LegacyWildcardConfigPatternMatcher are removed.

EE: https://github.com/hazelcast/hazelcast-enterprise/pull/3021

@pveentjer

This comment has been minimized.

Copy link
Member

pveentjer commented Jun 6, 2019

Doesn't make any sense to have duplicate exceptions. If an InvalidConfigurationException is thrown when the configuration is invalid, then a ConfigurationException is thrown when the configuration is... valid? :)

@vojtechtoman vojtechtoman self-requested a review Jun 6, 2019
These two are used interchangibly across the codebase. There is no point in having both of them. Also LegacyMatchongPointConfigPatternMatcher and LegacyWildcardConfigPatternMatcher are removed.
@mustafaiman mustafaiman force-pushed the mustafaiman:cleanup/unify-configuration-exceptions branch from 21adc2b to f8949b6 Jun 6, 2019
@mustafaiman mustafaiman merged commit 776c2e4 into hazelcast:master Jun 7, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mustafaiman mustafaiman deleted the mustafaiman:cleanup/unify-configuration-exceptions branch Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.