Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imap related public api to map package #15149

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@ahmetmircik
Copy link
Member

ahmetmircik commented Jun 11, 2019

@ahmetmircik ahmetmircik added this to the 4.0 milestone Jun 11, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/moveToMap branch from 61536a2 to 0a9f7f0 Jun 11, 2019
@@ -23,19 +23,19 @@
import com.hazelcast.console.LineReader;
import com.hazelcast.console.SimulateLoadTask;
import com.hazelcast.core.DistributedObject;
import com.hazelcast.core.EntryEvent;
import com.hazelcast.core.EntryListener;
import com.hazelcast.map.EntryEvent;

This comment has been minimized.

Copy link
@pveentjer

pveentjer Jun 12, 2019

Member

The MultiMap and replicatedMap also make use of EntryEvent. So I'm not sure if this should be moved to com.hz.map.

@@ -1834,7 +1834,7 @@
</xs:documentation>
<xs:appinfo>

This comment has been minimized.

Copy link
@pveentjer

pveentjer Jun 12, 2019

Member

Probably we don't want to change this (Better to toss the old xsd's in a different PR)

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/moveToMap branch 2 times, most recently from fa03dc5 to 3b25e98 Jun 12, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/moveToMap branch from 3b25e98 to b605800 Jun 27, 2019
@ahmetmircik ahmetmircik requested review from mmedenjak and pveentjer Jun 27, 2019
@ahmetmircik ahmetmircik marked this pull request as ready for review Jun 27, 2019
Copy link
Contributor

mmedenjak left a comment

Maybe you can also move com.hazelcast.core.BaseMap.

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/moveToMap branch from b605800 to d09d398 Jul 1, 2019
@ahmetmircik

This comment has been minimized.

Copy link
Member Author

ahmetmircik commented Jul 1, 2019

Maybe you can also move com.hazelcast.core.BaseMap.

@mmedenjak done.

@ahmetmircik ahmetmircik mentioned this pull request Jul 2, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/moveToMap branch from d09d398 to e9c975d Jul 3, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/moveToMap branch from e9c975d to de601b5 Jul 3, 2019
@ahmetmircik ahmetmircik merged commit 6fdf42d into hazelcast:master Jul 3, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@ahmetmircik ahmetmircik deleted the ahmetmircik:fix/4.0/moveToMap branch Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.