Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperated impl from com.hz.instance #15151

Conversation

@pveentjer
Copy link
Member

pveentjer commented Jun 12, 2019

So API is in com.hz.instance while the implementation is in
com.hz.instance.impl. So we don't need to be worried exposing
internals.

For EE see hazelcast/hazelcast-enterprise#3042

@mdogan
mdogan approved these changes Jun 12, 2019
@pveentjer pveentjer force-pushed the pveentjer:v4.0/cleanup/instance-package-api-seperation branch from cf9c9c1 to 35508f6 Jun 13, 2019
@@ -25,7 +26,7 @@
* interface do not have have to register themselves, as their {@link #onClusterVersionChange(Version)} method will be
* invoked automatically.
*
* Other listeners have to register themselves with {@link com.hazelcast.instance.NodeExtension#registerListener(Object)}.
* Other listeners have to register themselves with {@link NodeExtension#registerListener(Object)}.

This comment has been minimized.

Copy link
@mmedenjak

mmedenjak Jun 13, 2019

Contributor

Note for future PR - we will have to remove this as it is now private API.

@@ -46,12 +46,11 @@
import static java.util.Arrays.asList;
import static java.util.Collections.unmodifiableList;

@PrivateApi
public class DefaultNodeContext implements NodeContext {

public static final List<String> EXTENSION_PRIORITY_LIST = unmodifiableList(asList(
"com.hazelcast.instance.EnterpriseNodeExtension",

This comment has been minimized.

Copy link
@mmedenjak

mmedenjak Jun 13, 2019

Contributor

Need to change the EE class here.

This comment has been minimized.

Copy link
@emre-aydin

emre-aydin Jun 21, 2019

Contributor

@pveentjer I think this was missed? On current master, EnterpriseNodeExtension is not created due to wrong EE class name.

@pveentjer pveentjer force-pushed the pveentjer:v4.0/cleanup/instance-package-api-seperation branch from 35508f6 to ffb1f2b Jun 14, 2019
@pveentjer pveentjer force-pushed the pveentjer:v4.0/cleanup/instance-package-api-seperation branch 2 times, most recently from c75a977 to 19dd523 Jun 19, 2019
So API is in com.hz.instance while the implementation is in
com.hz.instance.impl. So we don't need to be worried exposing
internals.
@pveentjer pveentjer force-pushed the pveentjer:v4.0/cleanup/instance-package-api-seperation branch from 19dd523 to 6531b52 Jun 20, 2019
@pveentjer pveentjer merged commit c9bc406 into hazelcast:master Jun 20, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@pveentjer pveentjer deleted the pveentjer:v4.0/cleanup/instance-package-api-seperation branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.