Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nullable and Nonnull annotations to IQueue and fix some on IMap #15156

Merged
merged 3 commits into from Jul 3, 2019

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented Jun 12, 2019

Why should IMap be the only structure with a nice and clean API? It shouldn't! So we now add @Nullable and @Nonnull annotations to IQueue and do some minor cleanup.

Second commit is a small fix for the difference in behaviour of client and member-side IMap.addEntryListener.

Fixes: #15155

@mmedenjak mmedenjak added this to the 4.0 milestone Jun 12, 2019
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-queue-nullability branch from c4f3c56 to 5a7f668 Jun 19, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Jun 24, 2019

PR build failure caused by #15212

@mmedenjak mmedenjak self-assigned this Jul 2, 2019
@mmedenjak mmedenjak requested a review from ahmetmircik Jul 2, 2019
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-queue-nullability branch from 4e28e3c to b34cdf2 Jul 3, 2019
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-queue-nullability branch from b34cdf2 to 8387915 Jul 3, 2019
@mmedenjak mmedenjak merged commit 044db62 into hazelcast:master Jul 3, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak mmedenjak deleted the mmedenjak:4.0-queue-nullability branch Jul 3, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Jul 3, 2019

Thank you for the reviews, guys 🙇

petrpleshachkov pushed a commit to petrpleshachkov/hazelcast that referenced this pull request Jul 5, 2019
…azelcast#15156)

Add Nullable and Nonnull annotations to IQueue and fix some on IMap

Fixes: hazelcast#15155
petrpleshachkov pushed a commit to petrpleshachkov/hazelcast that referenced this pull request Jul 5, 2019
…azelcast#15156)

Add Nullable and Nonnull annotations to IQueue and fix some on IMap

Fixes: hazelcast#15155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.