Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved address to com.hz.cluster #15172

Closed

Conversation

@pveentjer
Copy link
Member

pveentjer commented Jun 14, 2019

The nio package is very dirty. Mix of API and internals. And Address
doesn't belong there at all.

The nio package is very dirty. Mix of API and internals. And Address
doesn't belong there at all.
@mdogan
mdogan approved these changes Jun 14, 2019
@pveentjer

This comment has been minimized.

Copy link
Member Author

pveentjer commented Aug 6, 2019

This PR causes problem with the client code generator.

@sancar

This comment has been minimized.

Copy link
Member

sancar commented Aug 19, 2019

@pveentjer Now you can rebase and make it compile. Client code generator will no longer cause a compile problem. We only need to merge hazelcast/hazelcast-client-protocol#211
when this pr is ready to keep them consistent.

sancar added a commit to sancar/hazelcast that referenced this pull request Oct 3, 2019
sancar added a commit to sancar/hazelcast that referenced this pull request Oct 3, 2019
@sancar

This comment has been minimized.

Copy link
Member

sancar commented Oct 3, 2019

@pveentjer Closing this because I will handle it here
#15666

@sancar sancar closed this Oct 3, 2019
sancar added a commit to sancar/hazelcast that referenced this pull request Oct 4, 2019
sancar added a commit to sancar/hazelcast that referenced this pull request Oct 4, 2019
sancar added a commit to sancar/hazelcast that referenced this pull request Oct 4, 2019
sancar added a commit to sancar/hazelcast that referenced this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.