Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3.x XSDs #15177

Merged
merged 4 commits into from Jun 17, 2019
Merged

Remove 3.x XSDs #15177

merged 4 commits into from Jun 17, 2019

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented Jun 14, 2019

The XSDs will change without backwards compatibility in 4.0 which means
there's no reason why we should keep them around as the parser will fail
anyway.

EE: hazelcast/hazelcast-enterprise#3045

Matko Medenjak
The XSDs will change without backwards compatibility in 4.0 which means
there's no reason why we should keep them around as the parser will fail
anyway.
@mdogan
mdogan approved these changes Jun 14, 2019
@mdogan

This comment has been minimized.

Copy link
Member

mdogan commented Jun 14, 2019

There's also spring.schemas file.

Matko Medenjak added 2 commits Jun 14, 2019
Matko Medenjak
Matko Medenjak
@@ -1,85 +0,0 @@
/*

This comment has been minimized.

Copy link
@mmedenjak

mmedenjak Jun 14, 2019

Author Contributor

I needed to delete these tests since they were starting instances with 3.8 and 3.9 versions, trying to dynamically add configuration which was added in later versions. The tests failed because they were looking for hazelcast-config-3.8.xsd and hazelcast-config-3.9.xsd. I've removed the tests since we no longer need to test if some config is accepted or not in older versions.

@sancar
sancar approved these changes Jun 17, 2019
@sancar sancar added the Team: Client label Jun 17, 2019
@mmedenjak mmedenjak merged commit 5d9b23b into hazelcast:master Jun 17, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Jun 17, 2019

Thanks for the reviews, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.