Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MerkleTreeConfig inside MapConfig #15180

Merged
merged 5 commits into from Jul 2, 2019

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented Jun 14, 2019

Initially, merkle tree configuration was put as a top-level config
because we were anticipating its' usage in cache as well but we were not
able to change CacheConfig because of client backwards compatibility
(see BinaryInterface annotation).
Now with 4.0, we will remove this restriction which means merkle tree
config can be part of both map and cache config (once it's implemented
for cache).
Using it this way will eliminate some of the confusion as up until now
the user had to additionally specify the mapName on the merkle tree
configuration to 'connect' the merkle tree configuration to the map
configuration.

Remaining:

  • change client protocol to remove merkle tree codec and append the map codec

EE: hazelcast/hazelcast-enterprise#3046
Client protocol PR: hazelcast/hazelcast-client-protocol#190

Copy link
Contributor

blazember left a comment

LGTM, assuming the TODOs should be resolved in a subsequent PR after the required client protocol change.

Matko Medenjak added 4 commits Jun 14, 2019
Initially, merkle tree configuration was put as a top-level config
because we were anticipating its' usage in cache as well but we were not
able to change CacheConfig because of client backwards compatibility
(see BinaryInterface annotation).
Now with 4.0, we will remove this restriction which means merkle tree
config can be part of both map and cache config (once it's implemented
for cache).
Using it this way will eliminate some of the confusion as up until now
the user had to additionally specify the mapName on the merkle tree
configuration to 'connect' the merkle tree configuration to the map
configuration.
Matko Medenjak
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-merkle-tree-config branch from 35a1d36 to 4c4f2ee Jul 2, 2019
@mmedenjak mmedenjak requested a review from vbekiaris Jul 2, 2019
Matko Medenjak
@mmedenjak mmedenjak merged commit dadce7e into hazelcast:master Jul 2, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak mmedenjak deleted the mmedenjak:4.0-merkle-tree-config branch Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.