Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EventJournalConfig inside MapConfig and CacheConfig #15185

Merged
merged 4 commits into from Jul 4, 2019

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented Jun 17, 2019

Initially, event journal configuration was put as a top-level config
because we are not able to change CacheConfig because of client
backwards compatibility (see BinaryInterface annotation).
Now with 4.0, we will remove this restriction which means event journal
config can be part of both map and cache config.
Using it this way will eliminate some of the confusion as up until now
the user had to additionally specify the mapName and cacheName on the
event journal configuration to 'connect' the event journal configuration
to the map configuration.

Remaining:

  • change client protocol to remove merkle tree codec and append the map codec

Depends on: #15180
EE: hazelcast/hazelcast-enterprise#3047
Client protocol PR: hazelcast/hazelcast-client-protocol#190

Copy link
Contributor

vbekiaris left a comment

Nice job, left some minor comments

@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Jun 26, 2019

@vbekiaris thanks for the review! It may not be easy to see from the PR but I've actually separated the PRs for moving the MerkleTreeConfig and moving the EventJournalConfig since I thought it would be easier for the reviewers. Maybe I was wrong and it should have been one single PR. Nevermind now, I'll keep it as-is and I'll address the merkle-tree related comments in the merkle-tree config PR.

@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-event-journal-config branch from c1f898e to 297bb97 Jun 26, 2019
mmedenjak pushed a commit to mmedenjak/hazelcast-client-protocol that referenced this pull request Jun 27, 2019
In 4.0 we move the EventJournalConfig and MerkleTreeConfig inside
MapConfig and CacheConfig. Up until 4.0 there were top-level
configurations because CacheConfig was a BinaryInterface.

Also, because they are part of MapConfig and CacheConfig, they will no
longer have the mapName and cacheName fields.

Depends on: hazelcast/hazelcast#15185
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-event-journal-config branch from 297bb97 to 7462429 Jul 2, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Jul 2, 2019

@vbekiaris Addressed review comments in the separate PR commit, please take a look.

Matko Medenjak added 3 commits Jun 17, 2019
Initially, event journal configuration was put as a top-level config
because we are not able to change CacheConfig because of client
backwards compatibility (see BinaryInterface annotation).
Now with 4.0, we will remove this restriction which means event journal
config can be part of both map and cache config.
Using it this way will eliminate some of the confusion as up until now
the user had to additionally specify the mapName and cacheName on the
event journal configuration to 'connect' the event journal configuration
to the map configuration.
Matko Medenjak
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-event-journal-config branch from 7462429 to 53f458a Jul 2, 2019
Matko Medenjak
@vojtechtoman vojtechtoman self-requested a review Jul 4, 2019
@mmedenjak mmedenjak merged commit effa5ea into hazelcast:master Jul 4, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak mmedenjak deleted the mmedenjak:4.0-event-journal-config branch Jul 4, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Jul 4, 2019

Thank you for the reviews, guys 🙇

petrpleshachkov pushed a commit to petrpleshachkov/hazelcast that referenced this pull request Jul 5, 2019
…5185)

Move EventJournalConfig inside MapConfig and CacheConfig

Initially, event journal configuration was put as a top-level config
because we are not able to change CacheConfig because of client
backwards compatibility (see BinaryInterface annotation).
Now with 4.0, we will remove this restriction which means event journal
config can be part of both map and cache config.
Using it this way will eliminate some of the confusion as up until now
the user had to additionally specify the mapName and cacheName on the
event journal configuration to 'connect' the event journal configuration
to the map configuration.
mmedenjak pushed a commit to mmedenjak/hazelcast-client-protocol that referenced this pull request Jul 25, 2019
In 4.0 we move the EventJournalConfig and MerkleTreeConfig inside
MapConfig and CacheConfig. Up until 4.0 there were top-level
configurations because CacheConfig was a BinaryInterface.

Also, because they are part of MapConfig and CacheConfig, they will no
longer have the mapName and cacheName fields.

Depends on: hazelcast/hazelcast#15185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.