Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not store map store instance in MapStoreConfig #15224
Additionally, the behaviour of storing the actual instance
Reasoning: the MapStoreConfig may have been added dynamically, so storing the actual map store instance in MapStoreConfig#implementation may result in failures as members join the cluster such as: - failure to serialize the MapStoreConfig, in case the map store class is not serializable - failure to deserialize the MapStoreConfig on the joining member side if the class is only resolvable over user code deployment, as the deserialization occurs within DynamicConfigPreJoinOperation deserialization, before members list is updated Additionally, the behaviour of storing the actual instance back in the implementation field is specific to MapStoreConfig and differs from any other similar config's behaviour (eg RingbufferStoreConfig).