Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the `MemberAttributeEvent` to include the list of existing members #15231

Merged

Conversation

@ihsandemir
Copy link
Contributor

ihsandemir commented Jun 28, 2019

Fixed MemberAttributeEvent getMembers method to return a correct members list for client.

related to #8241
related to hazelcast/hazelcast-client-protocol#191

@ihsandemir ihsandemir added this to the 4.0 milestone Jun 28, 2019
@ihsandemir ihsandemir requested review from sancar and asimarslan Jun 28, 2019
@ihsandemir ihsandemir self-assigned this Jun 28, 2019
@sancar sancar added the Team: Core label Jun 28, 2019
@sancar
sancar approved these changes Jul 2, 2019
/**
* This event type is fired if a member attribute has been changed or removed.
*
* @since 3.2

This comment has been minimized.

Copy link
@jerrinot

jerrinot Jul 2, 2019

Contributor

the since annotation makes little sense here.

…erver now returns the list of existing members when the event happened, to the client.
@ihsandemir ihsandemir force-pushed the ihsandemir:memberAttributeEventMembersRemoval branch from 9ed9546 to 2cb1573 Jul 3, 2019
ihsandemir added 2 commits Jul 3, 2019
Copy link
Contributor

jerrinot left a comment

and outdated PR description, otherwise LGTM!

public void handleMemberAttributeChangeEventV10(Member member, Collection<Member> members, String key, int opType,
String value) {
Collection<Member> currentMembersList = clusterService.getMemberList();
if (currentMembersList.contains(member)) {

This comment has been minimized.

Copy link
@sancar

sancar Jul 4, 2019

Member

This causes behavior to change. We need to check only the uuids. Contains use equals which also checks for address equality.

This comment has been minimized.

Copy link
@ihsandemir

ihsandemir Jul 4, 2019

Author Contributor

Ok, reverted back and opened and opened an issue #15271

@ihsandemir ihsandemir changed the title Removed the inheritance of MemberAttributeEvent from MembershipEvent … Change the `MemberAttributeEvent` to include the list of existing members Jul 4, 2019
@ihsandemir

This comment has been minimized.

Copy link
Contributor Author

ihsandemir commented Jul 4, 2019

and outdated PR description, otherwise LGTM!

Updated the issue description.

@sancar
sancar approved these changes Jul 4, 2019
@ihsandemir

This comment has been minimized.

Copy link
Contributor Author

ihsandemir commented Jul 23, 2019

run-lab-run

1 similar comment
@ihsandemir

This comment has been minimized.

Copy link
Contributor Author

ihsandemir commented Jul 23, 2019

run-lab-run

@ihsandemir ihsandemir merged commit 24b3a74 into hazelcast:master Jul 24, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@ihsandemir ihsandemir deleted the ihsandemir:memberAttributeEventMembersRemoval branch Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.