Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy merge policies #15292

Merged

Conversation

@ahmetmircik
Copy link
Member

ahmetmircik commented Jul 9, 2019

@ahmetmircik ahmetmircik added this to the 4.0 milestone Jul 9, 2019
@ahmetmircik ahmetmircik changed the title wip Remove legacy merge policies Jul 9, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/removeLegacyMergePolicies branch 4 times, most recently from f60b052 to 00d8462 Jul 10, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/removeLegacyMergePolicies branch 5 times, most recently from 03781d4 to 15b6bfc Jul 22, 2019
@ahmetmircik ahmetmircik marked this pull request as ready for review Jul 23, 2019
@ahmetmircik ahmetmircik requested a review from mmedenjak Jul 23, 2019
@vojtechtoman vojtechtoman self-requested a review Jul 24, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/removeLegacyMergePolicies branch from 15b6bfc to 64b14aa Jul 24, 2019
Copy link
Contributor

vojtechtoman left a comment

Looks good to me overall, but I found a small number of simple issues.

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/removeLegacyMergePolicies branch from 64b14aa to fdd38b4 Jul 24, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/removeLegacyMergePolicies branch from fdd38b4 to 3b9c68f Jul 25, 2019
Copy link
Contributor

mmedenjak left a comment

Great job and I'm so glad to see this legacy merging be removed 😌
Added some minor comments and I'm not sure about the MutatingOperations but other than that looks great!

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/removeLegacyMergePolicies branch 3 times, most recently from 8d892b4 to a702b11 Jul 30, 2019
@ahmetmircik ahmetmircik requested a review from mmedenjak Jul 30, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/removeLegacyMergePolicies branch from a702b11 to a8de399 Jul 30, 2019
@ahmetmircik ahmetmircik merged commit 108939a into hazelcast:master Jul 30, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@ahmetmircik ahmetmircik deleted the ahmetmircik:fix/4.0/removeLegacyMergePolicies branch Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.