Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding private client classes from public API #15377

Merged

Conversation

@sancar
Copy link
Member

sancar commented Jul 26, 2019

Moved following packages
client.connection -> client.impl.connection
client.proxy -> client.impl.proxy
client.spi.properties -> client.properties
client.spi -> client.impl.spi
client.util.ClientDelegatingFuture -> client.impl.ClientDelegatingFuture
client.api -> client

@sancar sancar added this to the 4.0 milestone Jul 26, 2019
@sancar sancar self-assigned this Jul 26, 2019
Moved following packages
client.connection -> client.impl.connection
client.proxy -> client.impl.proxy
client.spi.properties -> client.properties
client.spi -> client.impl.spi
client.util.ClientDelegatingFuture -> client.impl.ClientDelegatingFuture
client.api -> client
@sancar sancar force-pushed the sancar:ench/hidePrivateClientClasses/master branch from c663e5c to 45fe7f1 Jul 26, 2019
@pveentjer

This comment has been minimized.

Copy link
Member

pveentjer commented Jul 29, 2019

+1 for hiding implementations.

@sancar

This comment has been minimized.

Copy link
Member Author

sancar commented Jul 29, 2019

run-lab-run

1 similar comment
@sancar

This comment has been minimized.

Copy link
Member Author

sancar commented Jul 29, 2019

run-lab-run

@sancar sancar merged commit 5ac05d4 into hazelcast:master Jul 29, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@sancar sancar deleted the sancar:ench/hidePrivateClientClasses/master branch Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.