Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in WanConsistencyCheckIgnoredEvent #15400

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@blazember
Copy link
Contributor

blazember commented Jul 31, 2019

WanConsistencyCheckIgnoredEvent is sent to MC if

  • OS WAN is used,
  • EE is used, but merkle trees are not enabled.

In these cases, we fail fast, without assigning a UUID to the consistency check request. AbstractWanAntiEntropyEventBase.toJson however expects a non-null UUID and throws NPE. It is
fixed now by sending null as UUID.

These MC events don't have tests and the NPE was caught on the
MC side. MC replaces the JSON-based communication in 4.0, hence
currently no point in adding new tests to these JSON-based classes.

WanConsistencyCheckIgnoredEvent is sent to MC if
- OS WAN is used
- EE is used, but merkle trees are not enabled.

In these cases we fail fast, without assigning a UUID to the
consistency check request. AbstractWanAntiEntropyEventBase.toJson
however expected a non-null UUID and was throwing NPE. It is
fixed by sending "null" as UUID to MC.

These MC events don't have tests and the NPE was caught on the
MC side. MC replaces the JSON-based communication in 4.0, hence
currently no point adding new tests to these JSON-based classes.
@blazember blazember added this to the 4.0 milestone Jul 31, 2019
@blazember blazember self-assigned this Jul 31, 2019
@blazember

This comment has been minimized.

Copy link
Contributor Author

blazember commented Jul 31, 2019

@blazember blazember merged commit 4b798af into hazelcast:master Jul 31, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@blazember blazember deleted the blazember:4.0/fix/npe-in-wan-mc-events branch Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.