Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.hz.spi classes/interface privateapi #15401

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@pveentjer
Copy link
Member

pveentjer commented Jul 31, 2019

All the classes from the com.hz.spi package are made privateapi.

So if we are not ready in time cleaning up the com.hz.spi, these
classes are not for external consumption and therefor we can safely
move them in a later release.

We do not expect end users to write custom services. This was a goal
in 3.0, but not any longer.

@@ -44,6 +45,7 @@
* @see com.hazelcast.instance.DefaultAddressPicker
* @see com.hazelcast.config.NetworkConfig#setMemberAddressProviderConfig(com.hazelcast.config.MemberAddressProviderConfig)
*/
@PrivateApi
public interface MemberAddressProvider {

This comment has been minimized.

Copy link
@mdogan

mdogan Jul 31, 2019

Member

This is not private api, it's used by MemberAddressProviderConfig which is public.

This comment has been minimized.

Copy link
@pveentjer

pveentjer Jul 31, 2019

Author Member

Fixed

All the classes from the com.hz.spi package are made privateapi.

So if we are not ready in time cleaning up the com.hz.spi, these
classes are not for external consumption and therefor we can safely
move them in a later release.

We do not expect end users to write custom services. This was a goal
in 3.0, but not any longer.
@pveentjer pveentjer force-pushed the pveentjer:v4.0/cleanup/spi-privateapi branch from d9f9f97 to 4d95467 Jul 31, 2019
@mdogan
mdogan approved these changes Jul 31, 2019
@pveentjer pveentjer merged commit 66fd0dc into hazelcast:master Aug 1, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@pveentjer pveentjer deleted the pveentjer:v4.0/cleanup/spi-privateapi branch Aug 1, 2019
@pveentjer pveentjer mentioned this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.