Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big spi cleanup #15403

Merged
merged 1 commit into from Aug 5, 2019
Merged

Conversation

@pveentjer
Copy link
Member

pveentjer commented Aug 1, 2019

THe capability interfaces have been moved to com.hz.internal.services
Classes like AbstractDistributedObject have been moved to com.hz.spi.impl
And some internal interfaces have been flattened like InternalEventService
since it isn't exposed to end user any longer.

This task is a logical continuation of #15401

For the PRD see https://hazelcast.atlassian.net/wiki/spaces/PM/pages/1647936164/SPI+cleanup

For EE part see hazelcast/hazelcast-enterprise#3102

@pveentjer pveentjer added this to the 4.0 milestone Aug 1, 2019
@pveentjer pveentjer requested review from mdogan and mmedenjak Aug 1, 2019
@pveentjer pveentjer force-pushed the pveentjer:v4.0/cleanup/spi-big-cleanup branch from 6aa091d to 28a6669 Aug 1, 2019
@mdogan
mdogan approved these changes Aug 1, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor

mmedenjak commented Aug 3, 2019

We will have to remove custom services configuration - com.hazelcast.config.ServicesConfig and com.hazelcast.config.ServiceConfig. Ideally, I'd keep it as private as I think it's useful in writing tests and users still wanting to create custom services can use it, without any guarantees.

Also, we'll have to search for references of private API in public classes, such as this one.

THe capability interfaces have been moved to com.hz.internal.services
Classes like AbstractDistributedObject have been moved to com.hz.spi.impl
And some internal interfaces have been flattened like InternalEventService
since it isn't exposed to end user any longer
@pveentjer pveentjer force-pushed the pveentjer:v4.0/cleanup/spi-big-cleanup branch from 28a6669 to 2fc81e6 Aug 5, 2019
@pveentjer pveentjer merged commit 9e65699 into hazelcast:master Aug 5, 2019
1 check passed
1 check passed
default Test PASSed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.