Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of SecondsBasedEntryTaskScheduler (and thus transaction commit) #15414

Merged
merged 4 commits into from Sep 9, 2019

Conversation

@gdela
Copy link
Contributor

gdela commented Aug 2, 2019

A new implementation of SecondsBasedEntryTaskScheduler that is much faster in FOR_EACH mode, and this way improves performance of TransactionContext.commit(). See #15301 for details.

@devOpsHazelcast

This comment has been minimized.

Copy link
Contributor

devOpsHazelcast commented Aug 2, 2019

Can one of the admins verify this patch?

@gdela

This comment has been minimized.

Copy link
Contributor Author

gdela commented Aug 5, 2019

@mmedenjak Thanks for taking a look, there's also similar PR #15111 that also improves transactions performance, maybe you can consider merging both of them at the same time. I don't know when 4.0 is planned for, and I wonder whether I can also ask you to apply those changes to 3.x line to have them quicker. Should I do something to help you with that?

@mmedenjak mmedenjak self-requested a review Aug 6, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor

mmedenjak commented Aug 6, 2019

@gdela 4.0 is planned for fall this year. We can consider backporting this change once it's approved if we see that it's low risk and is compatible with patch releases.

Copy link
Contributor

mmedenjak left a comment

Looks good, only one comment to address

@mmedenjak mmedenjak requested a review from mdogan Sep 5, 2019
Copy link
Contributor

mmedenjak left a comment

Great job, thank you for the PR!

@mdogan
mdogan approved these changes Sep 9, 2019
@mmedenjak mmedenjak merged commit 8e691a8 into hazelcast:master Sep 9, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak

This comment has been minimized.

Copy link
Contributor

mmedenjak commented Sep 9, 2019

Thank you for the PR @gdela and the review @mdogan !

@gdela

This comment has been minimized.

Copy link
Contributor Author

gdela commented Sep 17, 2019

So my very first PR got through, thanks, I believe #15301 may be now considered solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.