Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Data from com.hz.nio.serialization #15419

Conversation

pveentjer
Copy link
Contributor

@pveentjer pveentjer commented Aug 5, 2019

to com.hz.internal.serialization. Data isn't public API, so it should be
removed from the com.hz.nio.serialization because this is the serialization API.

to com.hz.internal.serialization. Data isn't public API, so it should be
removed from the public API packages.
@pveentjer pveentjer added this to the 4.0 milestone Aug 5, 2019
Copy link
Contributor

@sancar sancar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pveentjer There is a problem with this change. Data is exposed from public API in ObjectDataInput.

@mmedenjak
Copy link
Contributor

As Sancar mentioned, Data is still exposed in the public ObjectDataOutput which is what the user gets when implementing DataSerializable or StreamSerializer. I assume we would need to hide the ObjectDataOutput#writeData behind private API first.

@mmedenjak
Copy link
Contributor

@mmedenjak mmedenjak closed this Nov 28, 2019
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants