Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nonnull and Nullable annotations and minor behaviour fixes #15442

Merged
merged 2 commits into from Oct 22, 2019

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented Aug 10, 2019

Adds Nonnull and Nullable annotations to HazelcastInstance,
CardinalityEstimator, IExecutor, DurableExecutor, QuorumService and some
others.
Aligned some behaviour of client and member-side when it comes to
behaviour with null parameters.
Added FunctionalInterface to MemberSelector and cleaned up some JDK8
code.

EE: hazelcast/hazelcast-enterprise#3115

@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-instance-nullability branch from 899fe66 to c70d072 Sep 4, 2019
@mmedenjak mmedenjak requested a review from vojtechtoman Sep 17, 2019
Copy link
Contributor

vojtechtoman left a comment

looks good to me

@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-instance-nullability branch from c70d072 to 124a2b7 Oct 1, 2019
@mmedenjak mmedenjak requested a review from hazelcast/clients as a code owner Oct 1, 2019
@asimarslan

This comment has been minimized.

Copy link
Member

asimarslan commented Oct 8, 2019

We need to apply the same idea to generated codecs.

Copy link
Member

asimarslan left a comment

client only

@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-instance-nullability branch from 124a2b7 to e898bc0 Oct 8, 2019
Adds Nonnull and Nullable annotations to HazelcastInstance,
CardinalityEstimator, IExecutor, DurableExecutor, QuorumService and some
others.
Aligned some behaviour of client and member-side when it comes to
behaviour with null parameters.
Added FunctionalInterface to MemberSelector and cleaned up some JDK8
code.
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-instance-nullability branch from e898bc0 to ad04b5a Oct 22, 2019
Matko Medenjak
@mmedenjak mmedenjak merged commit 2d0d65f into hazelcast:master Oct 22, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Oct 22, 2019

Thank you for the reviews @vojtechtoman @asimarslan !

@mmedenjak mmedenjak deleted the mmedenjak:4.0-instance-nullability branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.