Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert APIs that return UUID string to UUID #15473

Merged
merged 17 commits into from Sep 25, 2019

Conversation

@mdumandag
Copy link
Member

mdumandag commented Aug 20, 2019

Converted APIs that return UUID string to UUID. These includes Endpoint#getUUID, listener registrations/deregistrations, keys of replica timestamps of VectorClock, UUIDs in the executor service, UUID in the MigrationInfo, cluster id and transaction id.

EE: hazelcast/hazelcast-enterprise#3122

@mdumandag mdumandag added this to the 4.0 milestone Aug 20, 2019
@mdumandag mdumandag force-pushed the mdumandag:stringToUUID branch 3 times, most recently from 718a413 to fb87d5d Aug 20, 2019
@vojtechtoman vojtechtoman self-requested a review Aug 27, 2019
@vojtechtoman

This comment has been minimized.

Copy link
Contributor

vojtechtoman commented Sep 4, 2019

Here is a 🏅

@mdumandag mdumandag force-pushed the mdumandag:stringToUUID branch 4 times, most recently from 2a4ec99 to 20795f7 Sep 6, 2019
@mdumandag

This comment has been minimized.

Copy link
Member Author

mdumandag commented Sep 6, 2019

run-lab-run

@mdumandag mdumandag force-pushed the mdumandag:stringToUUID branch from 20795f7 to 9ee6dcc Sep 20, 2019
@mdumandag mdumandag requested a review from hazelcast/clients as a code owner Sep 20, 2019
@mdumandag mdumandag force-pushed the mdumandag:stringToUUID branch 2 times, most recently from 8d62181 to 0f3eb2a Sep 20, 2019
*/
public static String createClusterUuid() {
return newUnsecureUuidString();
public static UUID createClusterUuid() {

This comment has been minimized.

Copy link
@ihsandemir

ihsandemir Sep 20, 2019

Contributor

this and the following two methods are returning the same thing, can we merge them into single method, e.g. createUUID(). Or it can be removed totally and let the callers use newUnsecureUUID directly, there is no need for an extra redirection of methods.

This comment has been minimized.

Copy link
@mdumandag

mdumandag Sep 20, 2019

Author Member

Okay, I will change that

@mdumandag mdumandag force-pushed the mdumandag:stringToUUID branch 3 times, most recently from 7329ec8 to ec03169 Sep 23, 2019
@lazerion

This comment has been minimized.

Copy link
Contributor

lazerion commented Sep 24, 2019

@mdumandag Hi, I think this PR will break compile, may be also test failures on code-samples repo, kindly check after merge.

Copy link
Contributor

vojtechtoman left a comment

looks good to me

@mdumandag mdumandag force-pushed the mdumandag:stringToUUID branch from ec03169 to a794e58 Sep 24, 2019
@mdumandag

This comment has been minimized.

Copy link
Member Author

mdumandag commented Sep 24, 2019

run-lab-run

2 similar comments
@mdumandag

This comment has been minimized.

Copy link
Member Author

mdumandag commented Sep 24, 2019

run-lab-run

@mdumandag

This comment has been minimized.

Copy link
Member Author

mdumandag commented Sep 24, 2019

run-lab-run

@asimarslan asimarslan merged commit 2632299 into hazelcast:master Sep 25, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mdogan mdogan mentioned this pull request Sep 26, 2019
@mdumandag mdumandag deleted the mdumandag:stringToUUID branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.