Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forward Port] - Executor service message task should not block the partition thread #15522

Merged

Conversation

@ihsandemir
Copy link
Contributor

ihsandemir commented Sep 5, 2019

Forward ported #15526

@ihsandemir ihsandemir changed the title Client executor service submit methods failed to cancel server side task on Future `cancel` [Forward Port] - Executor service message task should not block the partition thread Sep 17, 2019
1. Change the `AbstractExecutorServiceCancelMessageTask` to be of type `AbstractPartitionMessageTask` and it is not `BlockingMessageTask`. It works similar to how map.get message task works. It will not block the partition thread.

2. Added new test (`testCancel_submitToKeyOwner_Should_Not_Block_Migration`) which tests if partition migration is blocked if the executor service cancel is called.
@ihsandemir ihsandemir force-pushed the ihsandemir:executorServiceSubmitToKeyOwnerFix branch from e4925cd to a87e68a Sep 17, 2019
@ihsandemir ihsandemir requested a review from hazelcast/clients as a code owner Sep 17, 2019
@ihsandemir ihsandemir requested a review from mdogan Sep 17, 2019
@mdogan
mdogan approved these changes Sep 18, 2019
@sancar
sancar approved these changes Sep 18, 2019
@ihsandemir ihsandemir merged commit 34868fe into hazelcast:master Sep 18, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@ihsandemir ihsandemir deleted the ihsandemir:executorServiceSubmitToKeyOwnerFix branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.