Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New index configuration API (#15265) #15537

Merged
merged 25 commits into from Oct 3, 2019
Merged

Conversation

@devozerov
Copy link
Member

devozerov commented Sep 11, 2019

Implementation of #15265

This patch introduces new IndexConfig which has the following advantages over the existing one:

  1. Ability to specify the index name
  2. Index type enumeration is used instead of boolean to allow for more than two index types in the future
  3. Columns are configured as a collection rather than as a comma-separated list
  4. Ability to specify column order in future

EE: hazelcast/hazelcast-enterprise#3154
Client protocol: hazelcast/hazelcast-client-protocol#219

@devozerov

This comment has been minimized.

Copy link
Member Author

devozerov commented Sep 11, 2019

run-lab-run

devozerov added 7 commits Sep 12, 2019
…exType, String...) instead.

2) Index.getComponents() now return String[] as earlier, instead of List<String>.
@vojtechtoman vojtechtoman self-requested a review Sep 23, 2019
devozerov added 3 commits Sep 24, 2019
@taburet taburet self-requested a review Sep 24, 2019
devozerov added 3 commits Sep 25, 2019
# Conflicts:
#	hazelcast/src/test/java/com/hazelcast/client/standalone/ClientEntryListenerDisconnectTest.java
#	hazelcast/src/test/java/com/hazelcast/map/EvictionTest.java
@devozerov devozerov requested a review from taburet Sep 25, 2019
Copy link
Contributor

vojtechtoman left a comment

Looks good to me now.

@taburet
taburet approved these changes Oct 1, 2019
Copy link
Contributor

taburet left a comment

LGTM too

@petrpleshachkov petrpleshachkov removed their request for review Oct 3, 2019
@devozerov

This comment has been minimized.

Copy link
Member Author

devozerov commented Oct 3, 2019

run-lab-run

@devozerov devozerov merged commit 82aedcf into hazelcast:master Oct 3, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@devozerov devozerov deleted the devozerov:issue/15265 branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.