Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove legacy CountdownLatch #15538
Removed legacy CountdownLatch implementation and
Protocol change: hazelcast/hazelcast-client-protocol#225
@asimarslan: I'm planning to send changes to the protocol repo. But I want to do that as the final step, since after
Last week I confirmed this with @mdumandag, he said that protocol and Hazelcast repo are not dependent to each other, so it's possible to do protocol changes after removing message-tasks and codecs.
Are you ok with this?
ihsandemir left a comment •
Codecs are manually modified and hence the generated message type ids are different.
I suggest that you regenerate the codecs instead of manual modification. But I realized that the protocol PR includes the other PR modifications for Semaphore and such and hence it may not be easy to separately generate just for CountdownLatch. This can be done: Generate it and revert the unrelated files changes to this PR such as Semaphore related ones. The current ids may be OK for this PR but whoever submits the next PR with protocol codec changes will have to do this is change anyway when he re-regenerates the codecs.