Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Semaphore #15539

Merged
merged 1 commit into from Sep 20, 2019
Merged

Remove legacy Semaphore #15539

merged 1 commit into from Sep 20, 2019

Conversation

@mdogan
Copy link
Member

mdogan commented Sep 11, 2019

Removed legacy Semaphore implementation and HazelcastInstance.getSemaphore(..) method. Instead we provide unsafe mode for all CP data structures (See #15184).

EE: hazelcast/hazelcast-enterprise#3156

See TDD: https://hazelcast.atlassian.net/wiki/spaces/EN/pages/1749057609/Concurrency+API+Clean-up+Design

Protocol change: hazelcast/hazelcast-client-protocol#226

@mdogan mdogan requested a review from hazelcast/clients as a code owner Sep 11, 2019
@mdogan mdogan added this to the 4.0 milestone Sep 11, 2019
@mdogan mdogan force-pushed the mdogan:remove-legacy-semaphore branch 6 times, most recently from 565123c to d1d84b0 Sep 11, 2019
@asimarslan

This comment has been minimized.

Copy link
Member

asimarslan commented Sep 16, 2019

@mdogan Can you send the client protocol changes to protocol repo too?

@asimarslan asimarslan self-requested a review Sep 16, 2019
@mdogan

This comment has been minimized.

Copy link
Member Author

mdogan commented Sep 17, 2019

@mdogan

This comment has been minimized.

Copy link
Member Author

mdogan commented Sep 17, 2019

@mmedenjak mmedenjak self-requested a review Sep 17, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor

mmedenjak commented Sep 18, 2019

Minor: we'll have to update the references to removed methods in javadoc, e.g. {@link HazelcastInstance#getSemaphore(String)}

@mdogan mdogan force-pushed the mdogan:remove-legacy-semaphore branch from d1d84b0 to 526009f Sep 20, 2019
@mdogan mdogan force-pushed the mdogan:remove-legacy-semaphore branch from 526009f to 7fd018d Sep 20, 2019
@mdogan mdogan force-pushed the mdogan:remove-legacy-semaphore branch from 7fd018d to 24e5563 Sep 20, 2019
@mdogan mdogan merged commit dd42ff6 into hazelcast:master Sep 20, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mdogan mdogan deleted the mdogan:remove-legacy-semaphore branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.