Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "group name" into "cluster name" #15540

Merged

Conversation

@petrpleshachkov
Copy link
Contributor

petrpleshachkov commented Sep 11, 2019

Moved (and renamed) groupName and groupPassword to the Config/ClientConfig
configuration classes. Removed GroupConfig configuration class.

EE part: hazelcast/hazelcast-enterprise#3157

@petrpleshachkov petrpleshachkov requested a review from hazelcast/clients as a code owner Sep 11, 2019
@petrpleshachkov petrpleshachkov force-pushed the petrpleshachkov:feature/master/cluster-name branch 3 times, most recently from 96977cc to 8da9886 Sep 12, 2019
@petrpleshachkov petrpleshachkov requested review from kwart and ahmetmircik Sep 13, 2019
@petrpleshachkov petrpleshachkov added this to the 4.0 milestone Sep 16, 2019
Copy link
Contributor

kwart left a comment

LGTM

@hazelcast hazelcast deleted a comment from petrpleshachkov Sep 16, 2019
@hazelcast hazelcast deleted a comment from petrpleshachkov Sep 16, 2019
@hazelcast hazelcast deleted a comment from petrpleshachkov Sep 16, 2019
throw new RuntimeException("GroupConfig cannot be null client is participate in XA Transaction");
public String getClusterName() {
final String clusterName = client.getClientConfig().getClusterName();
if (clusterName == null) {

This comment has been minimized.

Copy link
@ahmetmircik

ahmetmircik Sep 16, 2019

Member

how can a clusterName be null?

This comment has been minimized.

Copy link
@petrpleshachkov

petrpleshachkov Sep 16, 2019

Author Contributor

I will remove this if-block which is a leftover from old code.

@ahmetmircik

This comment has been minimized.

Copy link
Member

ahmetmircik commented Sep 16, 2019

@petrpleshachkov do we need a counterpart PR for management center?

Copy link
Member

ahmetmircik left a comment

LGTM

@petrpleshachkov petrpleshachkov dismissed stale reviews from ahmetmircik and kwart via 4a9b10f Sep 16, 2019
@petrpleshachkov petrpleshachkov requested review from kwart and ahmetmircik Sep 16, 2019
@petrpleshachkov

This comment has been minimized.

Copy link
Contributor Author

petrpleshachkov commented Sep 16, 2019

run-lab-run

@kwart
kwart approved these changes Sep 17, 2019
@sancar
sancar approved these changes Sep 18, 2019
Copy link
Contributor

kwart left a comment

I'm working on the typed security configuration which is the next step. IMO this PR should be put on hold now, as it's expected to be replaced by my changes.

@kwart
kwart approved these changes Sep 25, 2019
@kwart

This comment has been minimized.

Copy link
Contributor

kwart commented Sep 25, 2019

I've discussed the changes with @petrpleshachkov . We'll merge this after a rebase to latest master. I'll rebase my own changes afterward.

Moved (and renamed) groupName and groupPassword to the Config/ClientConfig
configuration classes. Removed GroupConfig configuration class.
Petr Pleshachkov
Minor code cleanup.
@petrpleshachkov petrpleshachkov force-pushed the petrpleshachkov:feature/master/cluster-name branch from 4a9b10f to 91ec8f3 Sep 25, 2019
Petr Pleshachkov
Fixed checkstyle warnings.
@petrpleshachkov petrpleshachkov merged commit d035821 into hazelcast:master Sep 25, 2019
1 check passed
1 check passed
default Test PASSed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.