Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed MapAttributeConfig and it's "extractor" field (#15547) #15548

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@devozerov
Copy link
Member

devozerov commented Sep 13, 2019

PR for task #15547:

  1. MapAttributeConfig is renamed to AttributeConfig
  2. extractor field is renamed to extractorClassName

Client protocol PR: hazelcast/hazelcast-client-protocol#220

@devozerov devozerov requested a review from hazelcast/clients as a code owner Sep 13, 2019
@devozerov devozerov changed the title Renamed MapAttributeConfig (#15265) Renamed MapAttributeConfig and it's "extractor" field (#15265) Sep 13, 2019
@devozerov devozerov changed the title Renamed MapAttributeConfig and it's "extractor" field (#15265) Renamed MapAttributeConfig and it's "extractor" field (#15547) Sep 13, 2019
@mmedenjak mmedenjak added this to the 4.0 milestone Sep 13, 2019
@devozerov

This comment has been minimized.

Copy link
Member Author

devozerov commented Sep 13, 2019

run-lab-run

@ihsandemir ihsandemir self-requested a review Sep 16, 2019
Copy link
Contributor

vojtechtoman left a comment

Looks good to me

@devozerov devozerov merged commit aaae0ef into hazelcast:master Sep 17, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@devozerov devozerov deleted the devozerov:issue/15547 branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.