Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SplitBrainProtection API method #15554

Conversation

@petrpleshachkov
Copy link
Contributor

petrpleshachkov commented Sep 17, 2019

Renamed isMinimumClusterSizeSatisfied() -> hasMinimumSize().

Petr Pleshachkov
Renamed isMinimumClusterSizeSatisfied() -> hasMinimumSize().
@@ -162,7 +162,7 @@ public SplitBrainProtectionConfig getConfig() {
}

@Override
public boolean isMinimumClusterSizeSatisfied() {
public boolean hasMinimumSize() {
return splitBrainProtectionState == SplitBrainProtectionState.MIN_CLUSTER_SIZE_SATISFIED;

This comment has been minimized.

Copy link
@ahmetmircik

ahmetmircik Sep 17, 2019

Member

minor: This SplitBrainProtectionState.MIN_CLUSTER_SIZE_SATISFIED can also be renamed.

Copy link
Member

ahmetmircik left a comment

LGTM + (Quorum was a better name :))

@mmedenjak

This comment has been minimized.

Copy link
Contributor

mmedenjak commented Sep 18, 2019

run-lab-run

Petr Pleshachkov
Renamed SplitBrainProtectionState enum values.
@petrpleshachkov

This comment has been minimized.

Copy link
Contributor Author

petrpleshachkov commented Sep 25, 2019

run-lab-run

@petrpleshachkov

This comment has been minimized.

Copy link
Contributor Author

petrpleshachkov commented Sep 25, 2019

Guys, thanks for the review. I am merging the PR.

@petrpleshachkov petrpleshachkov merged commit fedb8b0 into hazelcast:master Sep 25, 2019
1 check passed
1 check passed
default Test PASSed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.