Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute client graceful shutdown tasks before marking as inactive #15565

Merged

Conversation

@mdogan
Copy link
Member

commented Sep 18, 2019

Graceful shutdown tasks are needed to do cleanup of resources allocated
on server side. These resources are released after a HB timeout but during
a graceful shutdown, an immediate release is expected instead of a timeout.

But in some cases, missing connection etc, these request may retry.
If client is marked as inactive at that point, retry tasks will fail
without actually retrying. And that causes cleanup to fail.

Instead, we execute graceful shutdown tasks before marking client as inactive.

Fixes #15399
Fixes #15550

Backport of #15564

Graceful shutdown tasks are needed to do cleanup of resources allocated
on server side. These resources are released after a HB timeout but during
a graceful shutdown, an immediate release is expected instead of a timeout.

But in some cases, missing connection etc, these request may retry.
If client is marked as inactive at that point, retry tasks will fail
without actually retrying. And that causes cleanup to fail.

Instead, we execute graceful shutdown tasks before marking client as inactive.
@mdogan mdogan merged commit f14cbd9 into hazelcast:maintenance-3.x Sep 23, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mdogan mdogan deleted the mdogan:client-graceful-shutdown-fix-x branch Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.