Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move com.hazelcast.util classes to internal package #15570

Merged
merged 4 commits into from Sep 19, 2019

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented Sep 18, 2019

All classes in com.hazelcast.util are private API. The package-info.java
says so but moving the classes into the internal package makes it
obvious, even for users not reading the package-info.

Merges the OS and EE com.hazelcast.internal.util.TimeUtil because of an
identical fully qualified class name. Other than this and package/import
changes, there is no code or behaviour change.

EE: hazelcast/hazelcast-enterprise#3163

@mmedenjak mmedenjak added this to the 4.0 milestone Sep 18, 2019
@mmedenjak mmedenjak requested a review from hazelcast/clients as a code owner Sep 18, 2019
@mmedenjak mmedenjak self-assigned this Sep 18, 2019
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-private-api-util branch from f4391c2 to 4ee8d51 Sep 18, 2019
@sancar
sancar approved these changes Sep 19, 2019
@mdogan
mdogan approved these changes Sep 19, 2019
Matko Medenjak added 3 commits Sep 18, 2019
All classes in com.hazelcast.util are private API. The package-info.java
says so but moving the classes into the internal package makes it
obvious, even for users not reading the package-info.

Merges the OS and EE com.hazelcast.internal.util.TimeUtil because of an
identical fully qualified class name. Other than this and package/import
changes, there is no code or behaviour change.
Matko Medenjak
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-private-api-util branch from be7dee9 to c25ed31 Sep 19, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Sep 19, 2019

Note to self: need to update hazelcast-aws and hazelcast-kubernetes module after this is merged. #15576

Matko Medenjak
@mmedenjak mmedenjak merged commit 86a759a into hazelcast:master Sep 19, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak mmedenjak deleted the mmedenjak:4.0-private-api-util branch Sep 19, 2019
mmedenjak pushed a commit to mmedenjak/hazelcast-aws that referenced this pull request Sep 23, 2019
Address compilation issue because of
hazelcast/hazelcast#15570.
mmedenjak pushed a commit to mmedenjak/hazelcast-kubernetes that referenced this pull request Sep 23, 2019
Address compilation and packaging issues because of
hazelcast/hazelcast#15570.
leszko added a commit to hazelcast/hazelcast-kubernetes that referenced this pull request Sep 23, 2019
Address compilation and packaging issues because of
hazelcast/hazelcast#15570.
hasancelik added a commit to hasancelik/hazelcast-kubernetes that referenced this pull request Oct 4, 2019
hasancelik added a commit to hazelcast/hazelcast-kubernetes that referenced this pull request Oct 7, 2019
Address compilation and packaging issues because of
hazelcast/hazelcast#15570.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.