Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WAN prefix with Wan #15571

Merged
merged 1 commit into from Sep 19, 2019
Merged

Conversation

@ahmetmircik
Copy link
Member

ahmetmircik commented Sep 19, 2019

Reason is to have consistent naming with other Wan classes.

ee counterpart: hazelcast/hazelcast-enterprise#3164

@ahmetmircik ahmetmircik requested a review from mmedenjak Sep 19, 2019
@ahmetmircik ahmetmircik requested a review from hazelcast/clients as a code owner Sep 19, 2019
Copy link
Member

mdumandag left a comment

Why are the old files (WANReplicationQueueFullException.java and WANQueueFullBehavior.java) not deleted ?

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/renameWAN branch from 449f810 to a71d917 Sep 19, 2019
@ahmetmircik

This comment has been minimized.

Copy link
Member Author

ahmetmircik commented Sep 19, 2019

@mdumandag it is a rename operation, the files are shown as renamed in PR.

@ahmetmircik

This comment has been minimized.

Copy link
Member Author

ahmetmircik commented Sep 19, 2019

com.hazelcast.client.map.ClientMapTest.testAsyncPutAll
http://jenkins.hazelcast.com/job/Hazelcast-pr-builder/3174/

@ahmetmircik

This comment has been minimized.

Copy link
Member Author

ahmetmircik commented Sep 19, 2019

run-lab-run

@ahmetmircik ahmetmircik merged commit 9f84a74 into hazelcast:master Sep 19, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@ahmetmircik ahmetmircik deleted the ahmetmircik:fix/4.0/renameWAN branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.