Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move private NIO and serialization classes to internal package #15599

Merged
merged 3 commits into from Sep 24, 2019

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented Sep 23, 2019

Another "broad stroke" change in moving private API from public to
internal package, this time mostly for the NIO and serialization
package. Other than moving the classes, fixing checkstyle issues
and the occassional reformatting, there is no code or behaviour
change.

EE: hazelcast/hazelcast-enterprise#3173
Classes moved but then reverted:
com.hazelcast.nio.MemberSocketInterceptor
com.hazelcast.nio.SocketInterceptor

Classes moved:
com.hazelcast.client.ClientExtension

com.hazelcast.nio.ascii.AllowingTextProtocolFilter
com.hazelcast.nio.ascii.MemcacheTextDecoder
com.hazelcast.nio.ascii.RestApiFilter
com.hazelcast.nio.ascii.RestApiTextDecoder
com.hazelcast.nio.ascii.TextChannelInitializer
com.hazelcast.nio.ascii.TextDecoder
com.hazelcast.nio.ascii.TextEncoder
com.hazelcast.nio.ascii.TextParsers
com.hazelcast.nio.ascii.TextProtocolFilter

com.hazelcast.nio.tcp.AbstractChannelInitializer
com.hazelcast.nio.tcp.BindHandler
com.hazelcast.nio.tcp.BindRequest
com.hazelcast.nio.tcp.ClientChannelInitializer
com.hazelcast.nio.tcp.ClientViewUnifiedEndpointManager
com.hazelcast.nio.tcp.DefaultChannelInitializerProvider
com.hazelcast.nio.tcp.MemberChannelInitializer
com.hazelcast.nio.tcp.MemberProtocolEncoder
com.hazelcast.nio.tcp.MemberViewUnifiedEndpointManager
com.hazelcast.nio.tcp.PacketDecoder
com.hazelcast.nio.tcp.PacketEncoder
com.hazelcast.nio.tcp.SingleProtocolDecoder
com.hazelcast.nio.tcp.TcpIpAcceptor
com.hazelcast.nio.tcp.TcpIpConnection
com.hazelcast.nio.tcp.TcpIpConnectionChannelErrorHandler
com.hazelcast.nio.tcp.TcpIpConnectionErrorHandler
com.hazelcast.nio.tcp.TcpIpConnector
com.hazelcast.nio.tcp.TcpIpEndpointManager
com.hazelcast.nio.tcp.TcpIpNetworkingService
com.hazelcast.nio.tcp.TcpIpUnifiedEndpointManager
com.hazelcast.nio.tcp.TextHandshakeDecoder
com.hazelcast.nio.tcp.TextViewUnifiedEndpointManager
com.hazelcast.nio.tcp.UnifiedChannelInitializer
com.hazelcast.nio.tcp.UnifiedProtocolDecoder
com.hazelcast.nio.tcp.UnifiedProtocolEncoder

com.hazelcast.nio.AggregateEndpointManager
com.hazelcast.nio.Bits
com.hazelcast.nio.BufferObjectDataInput
com.hazelcast.nio.BufferObjectDataOutput
com.hazelcast.nio.ClassLoaderUtil
com.hazelcast.nio.Connection
com.hazelcast.nio.ConnectionLifecycleListener
com.hazelcast.nio.ConnectionListenable
com.hazelcast.nio.ConnectionListener
com.hazelcast.nio.ConnectionType
com.hazelcast.nio.DefaultAggregateEndpointManager
com.hazelcast.nio.Disposable
com.hazelcast.nio.EndpointManager
com.hazelcast.nio.IOService
com.hazelcast.nio.IOUtil
com.hazelcast.nio.NetworkingService
com.hazelcast.nio.NodeIOService
com.hazelcast.nio.Packet
com.hazelcast.nio.PacketIOHelper
com.hazelcast.nio.Protocols
com.hazelcast.nio.UnifiedAggregateEndpointManager

com.hazelcast.nio.serialization.BinaryInterface
com.hazelcast.nio.serialization.DataType
com.hazelcast.nio.serialization.SerializableByConvention
com.hazelcast.nio.serialization.SerializationClassNameFilter

com.hazelcast.nio.tcp.SymmetricCipherPacketDecoder
com.hazelcast.nio.tcp.SymmetricCipherPacketEncoder

Matko Medenjak added 2 commits Sep 23, 2019
Another "broad stroke" change in moving private API from public to
internal package, this time mostly for the NIO and serialization
package. Other than moving the classes, there is no code or behaviour
change.

Classes moved:
com.hazelcast.client.ClientExtension

com.hazelcast.nio.ascii.AllowingTextProtocolFilter
com.hazelcast.nio.ascii.MemcacheTextDecoder
com.hazelcast.nio.ascii.RestApiFilter
com.hazelcast.nio.ascii.RestApiTextDecoder
com.hazelcast.nio.ascii.TextChannelInitializer
com.hazelcast.nio.ascii.TextDecoder
com.hazelcast.nio.ascii.TextEncoder
com.hazelcast.nio.ascii.TextParsers
com.hazelcast.nio.ascii.TextProtocolFilter

com.hazelcast.nio.tcp.AbstractChannelInitializer
com.hazelcast.nio.tcp.BindHandler
com.hazelcast.nio.tcp.BindRequest
com.hazelcast.nio.tcp.ClientChannelInitializer
com.hazelcast.nio.tcp.ClientViewUnifiedEndpointManager
com.hazelcast.nio.tcp.DefaultChannelInitializerProvider
com.hazelcast.nio.tcp.MemberChannelInitializer
com.hazelcast.nio.tcp.MemberProtocolEncoder
com.hazelcast.nio.tcp.MemberViewUnifiedEndpointManager
com.hazelcast.nio.tcp.PacketDecoder
com.hazelcast.nio.tcp.PacketEncoder
com.hazelcast.nio.tcp.SingleProtocolDecoder
com.hazelcast.nio.tcp.TcpIpAcceptor
com.hazelcast.nio.tcp.TcpIpConnection
com.hazelcast.nio.tcp.TcpIpConnectionChannelErrorHandler
com.hazelcast.nio.tcp.TcpIpConnectionErrorHandler
com.hazelcast.nio.tcp.TcpIpConnector
com.hazelcast.nio.tcp.TcpIpEndpointManager
com.hazelcast.nio.tcp.TcpIpNetworkingService
com.hazelcast.nio.tcp.TcpIpUnifiedEndpointManager
com.hazelcast.nio.tcp.TextHandshakeDecoder
com.hazelcast.nio.tcp.TextViewUnifiedEndpointManager
com.hazelcast.nio.tcp.UnifiedChannelInitializer
com.hazelcast.nio.tcp.UnifiedProtocolDecoder
com.hazelcast.nio.tcp.UnifiedProtocolEncoder

com.hazelcast.nio.AggregateEndpointManager
com.hazelcast.nio.Bits
com.hazelcast.nio.BufferObjectDataInput
com.hazelcast.nio.BufferObjectDataOutput
com.hazelcast.nio.ClassLoaderUtil
com.hazelcast.nio.Connection
com.hazelcast.nio.ConnectionLifecycleListener
com.hazelcast.nio.ConnectionListenable
com.hazelcast.nio.ConnectionListener
com.hazelcast.nio.ConnectionType
com.hazelcast.nio.DefaultAggregateEndpointManager
com.hazelcast.nio.Disposable
com.hazelcast.nio.EndpointManager
com.hazelcast.nio.IOService
com.hazelcast.nio.IOUtil
com.hazelcast.nio.MemberSocketInterceptor
com.hazelcast.nio.NetworkingService
com.hazelcast.nio.NodeIOService
com.hazelcast.nio.Packet
com.hazelcast.nio.PacketIOHelper
com.hazelcast.nio.Protocols
com.hazelcast.nio.SocketInterceptor
com.hazelcast.nio.UnifiedAggregateEndpointManager

com.hazelcast.nio.serialization.BinaryInterface
com.hazelcast.nio.serialization.DataType
com.hazelcast.nio.serialization.SerializableByConvention
com.hazelcast.nio.serialization.SerializationClassNameFilter

com.hazelcast.nio.tcp.SymmetricCipherPacketDecoder
com.hazelcast.nio.tcp.SymmetricCipherPacketEncoder
Matko Medenjak
@mmedenjak mmedenjak added this to the 4.0 milestone Sep 23, 2019
@mmedenjak mmedenjak requested review from pveentjer and vbekiaris Sep 23, 2019
@mmedenjak mmedenjak requested a review from hazelcast/clients as a code owner Sep 23, 2019
@mmedenjak mmedenjak self-assigned this Sep 23, 2019
@pveentjer

This comment has been minimized.

Copy link
Member

pveentjer commented Sep 23, 2019

I believe socket interceptor is public API. The idea is that custom implementations can be made.

@pveentjer

This comment has been minimized.

Copy link
Member

pveentjer commented Sep 24, 2019

Looks good to me

@sancar
sancar approved these changes Sep 24, 2019
Copy link
Contributor

vbekiaris left a comment

looks good.

note to reviewers: document.querySelectorAll('.load-diff-button').forEach(node => node.click()) will expand all "load diffs" sections

@mmedenjak mmedenjak merged commit 05fb452 into hazelcast:master Sep 24, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak mmedenjak deleted the mmedenjak:4.0-private-api-cleanup-2 branch Sep 24, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Sep 24, 2019

Thank you for the reviews, guys! I think the end is close (although I said the same thing the last time :) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.