Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hot restart private classes to internal package #15603

Merged
merged 1 commit into from Sep 29, 2019

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented Sep 24, 2019

Moves internal hot restart classes from public to private API. Most
classes were in com.hazelcast.spi.hotrestart and since it is not an
actual SPI, all classes were moved to com.hazelcast.internal.hotrestart,
including already private classes like those in
com.hazelcast.spi.hotrestart.impl. Other than moving the classes and
fixing checkstyle, there is no code or behaviour change.

EE: hazelcast/hazelcast-enterprise#3176

Classes moved:
com.hazelcast.hotrestart.InternalHotRestartService
com.hazelcast.hotrestart.NoOpHotRestartService
com.hazelcast.hotrestart.NoopInternalHotRestartService

com.hazelcast.cache.hotrestart.HotRestartEnterpriseCacheRecordStore

com.hazelcast.spi.hotrestart.backup.HotRestartBackupInterruptOperation
com.hazelcast.spi.hotrestart.backup.HotRestartBackupOperation
com.hazelcast.spi.hotrestart.backup.HotRestartBackupSerializerHook
com.hazelcast.spi.hotrestart.backup.HotRestartBackupTransactionLogRecord

com.hazelcast.spi.hotrestart.cluster.AbstractMetadataReader
com.hazelcast.spi.hotrestart.cluster.AbstractMetadataWriter
com.hazelcast.spi.hotrestart.cluster.AskForClusterStartResultOperation
com.hazelcast.spi.hotrestart.cluster.AskForExpectedMembersOperation
com.hazelcast.spi.hotrestart.cluster.ClusterHotRestartEventListener
com.hazelcast.spi.hotrestart.cluster.ClusterHotRestartStatusDTOUtil
com.hazelcast.spi.hotrestart.cluster.ClusterMetadataManager
com.hazelcast.spi.hotrestart.cluster.ClusterMetadataWriterLoop
com.hazelcast.spi.hotrestart.cluster.ClusterStateReader
com.hazelcast.spi.hotrestart.cluster.ClusterStateWriter
com.hazelcast.spi.hotrestart.cluster.ClusterVersionReader
com.hazelcast.spi.hotrestart.cluster.ClusterVersionWriter
com.hazelcast.spi.hotrestart.cluster.HotRestartClusterSerializerHook
com.hazelcast.spi.hotrestart.cluster.HotRestartClusterStartStatus
com.hazelcast.spi.hotrestart.cluster.LocalMemberReader
com.hazelcast.spi.hotrestart.cluster.MemberClusterStartInfo
com.hazelcast.spi.hotrestart.cluster.MemberListReader
com.hazelcast.spi.hotrestart.cluster.MemberListWriter
com.hazelcast.spi.hotrestart.cluster.package-info
com.hazelcast.spi.hotrestart.cluster.PartitionTableReader
com.hazelcast.spi.hotrestart.cluster.PartitionTableWriter
com.hazelcast.spi.hotrestart.cluster.PartitionThreadCountReader
com.hazelcast.spi.hotrestart.cluster.PartitionThreadCountWriter
com.hazelcast.spi.hotrestart.cluster.SendClusterStartResultOperation
com.hazelcast.spi.hotrestart.cluster.SendExcludedMemberUuidsOperation
com.hazelcast.spi.hotrestart.cluster.SendExpectedMembersOperation
com.hazelcast.spi.hotrestart.cluster.SendMemberClusterStartInfoOperation
com.hazelcast.spi.hotrestart.cluster.TriggerForceStartOnMasterOperation

com.hazelcast.spi.hotrestart.memory.HotRestartPoolingMemoryManager
com.hazelcast.spi.hotrestart.memory.HotRestartThreadLocalPoolingMemoryManager

com.hazelcast.spi.hotrestart.ConfigDescriptor
com.hazelcast.spi.hotrestart.ForceStartException
com.hazelcast.spi.hotrestart.HotBackupService
com.hazelcast.spi.hotrestart.HotRestartIntegrationService
com.hazelcast.spi.hotrestart.LoadedConfigurationListener
com.hazelcast.spi.hotrestart.PersistentConfigDescriptors
com.hazelcast.spi.hotrestart.RamStoreHelper

com.hazelcast.spi.hotrestart.impl.di.DiContainer
com.hazelcast.spi.hotrestart.impl.di.DiException
com.hazelcast.spi.hotrestart.impl.di.Initialize
com.hazelcast.spi.hotrestart.impl.di.Inject
com.hazelcast.spi.hotrestart.impl.di.Name

com.hazelcast.spi.hotrestart.impl.gc.chunk.ActiveChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.ActiveValChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.Chunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.EmptyLongSet
com.hazelcast.spi.hotrestart.impl.gc.chunk.GrowingChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.StableChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.StableTombChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.StableValChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.SurvivorValChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.WriteThroughChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.WriteThroughTombChunk

com.hazelcast.spi.hotrestart.impl.gc.mem.MmapMalloc
com.hazelcast.spi.hotrestart.impl.gc.mem.MmapSlab

com.hazelcast.spi.hotrestart.impl.gc.record.Record
com.hazelcast.spi.hotrestart.impl.gc.record.RecordDataHolder
com.hazelcast.spi.hotrestart.impl.gc.record.RecordMap
com.hazelcast.spi.hotrestart.impl.gc.record.RecordMapOffHeap
com.hazelcast.spi.hotrestart.impl.gc.record.RecordMapOnHeap
com.hazelcast.spi.hotrestart.impl.gc.record.RecordOffHeap
com.hazelcast.spi.hotrestart.impl.gc.record.RecordOnHeap
com.hazelcast.spi.hotrestart.impl.gc.record.SetOfKeyHandleOffHeap
com.hazelcast.spi.hotrestart.impl.gc.record.SetOfKeyHandleOnHeap
com.hazelcast.spi.hotrestart.impl.gc.record.SortedBySeqRecordCursorOffHeap
com.hazelcast.spi.hotrestart.impl.gc.record.SortedBySeqRecordCursorOnHeap

com.hazelcast.spi.hotrestart.impl.gc.tracker.Tracker
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerMap
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerMapBase
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerMapOffHeap
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerMapOnHeap
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerOffHeap
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerOnHeap

com.hazelcast.spi.hotrestart.impl.gc.BackupExecutor
com.hazelcast.spi.hotrestart.impl.gc.BackupTask
com.hazelcast.spi.hotrestart.impl.gc.ChunkManager
com.hazelcast.spi.hotrestart.impl.gc.ChunkPriorityQueue
com.hazelcast.spi.hotrestart.impl.gc.GcExecutor
com.hazelcast.spi.hotrestart.impl.gc.GcHelper
com.hazelcast.spi.hotrestart.impl.gc.GcLogger
com.hazelcast.spi.hotrestart.impl.gc.GcMainLoop
com.hazelcast.spi.hotrestart.impl.gc.GcParams
com.hazelcast.spi.hotrestart.impl.gc.MutatorCatchup
com.hazelcast.spi.hotrestart.impl.gc.package-info
com.hazelcast.spi.hotrestart.impl.gc.PrefixTombstoneManager
com.hazelcast.spi.hotrestart.impl.gc.Rebuilder
com.hazelcast.spi.hotrestart.impl.gc.Snapshotter
com.hazelcast.spi.hotrestart.impl.gc.TombChunkSelector
com.hazelcast.spi.hotrestart.impl.gc.TombEvacuator
com.hazelcast.spi.hotrestart.impl.gc.ValChunkSelector
com.hazelcast.spi.hotrestart.impl.gc.ValEvacuator

com.hazelcast.spi.hotrestart.impl.io.ChunkFileCursor
com.hazelcast.spi.hotrestart.impl.io.ChunkFileOut
com.hazelcast.spi.hotrestart.impl.io.ChunkFileRecord
com.hazelcast.spi.hotrestart.impl.io.ChunkFilesetCursor
com.hazelcast.spi.hotrestart.impl.io.DefaultCopyStrategy
com.hazelcast.spi.hotrestart.impl.io.FileCopyStrategy
com.hazelcast.spi.hotrestart.impl.io.HardLinkCopyStrategy
com.hazelcast.spi.hotrestart.impl.io.TombFileAccessor

com.hazelcast.spi.hotrestart.impl.ConcurrentHotRestartStore
com.hazelcast.spi.hotrestart.impl.HotRestarter
com.hazelcast.spi.hotrestart.impl.HotRestartModule
com.hazelcast.spi.hotrestart.impl.HotRestartPersistenceEngine
com.hazelcast.spi.hotrestart.impl.HotRestartStoreConfig
com.hazelcast.spi.hotrestart.impl.KeyOffHeap
com.hazelcast.spi.hotrestart.impl.KeyOnHeap
com.hazelcast.spi.hotrestart.impl.package-info
com.hazelcast.spi.hotrestart.impl.RamStoreRestartLoop
com.hazelcast.spi.hotrestart.impl.RestartItem
com.hazelcast.spi.hotrestart.impl.RunnableWithStatus
com.hazelcast.spi.hotrestart.impl.SetOfKeyHandle
com.hazelcast.spi.hotrestart.impl.SimpleHandleOffHeap
com.hazelcast.spi.hotrestart.impl.SortedBySeqRecordCursor

com.hazelcast.spi.hotrestart.HotRestartException
com.hazelcast.spi.hotrestart.HotRestartKey
com.hazelcast.spi.hotrestart.HotRestartStore
com.hazelcast.spi.hotrestart.KeyHandle
com.hazelcast.spi.hotrestart.KeyHandleOffHeap
com.hazelcast.spi.hotrestart.RamStore
com.hazelcast.spi.hotrestart.RamStoreRegistry
com.hazelcast.spi.hotrestart.RecordDataSink

@mdogan
mdogan approved these changes Sep 25, 2019
@mmedenjak mmedenjak requested a review from vojtechtoman Sep 25, 2019
Copy link
Contributor

vojtechtoman left a comment

Looks good to me.

Moves internal hot restart classes from public to private API. Most
classes were in com.hazelcast.spi.hotrestart and since it is not an
actual SPI, all classes were moved to com.hazelcast.internal.hotrestart,
including already private classes like those in
com.hazelcast.spi.hotrestart.impl. Other than moving the classes and
fixing checkstyle, there is no code or behaviour change.

Classes moved:
com.hazelcast.hotrestart.InternalHotRestartService
com.hazelcast.hotrestart.NoOpHotRestartService
com.hazelcast.hotrestart.NoopInternalHotRestartService

com.hazelcast.cache.hotrestart.HotRestartEnterpriseCacheRecordStore

com.hazelcast.spi.hotrestart.backup.HotRestartBackupInterruptOperation
com.hazelcast.spi.hotrestart.backup.HotRestartBackupOperation
com.hazelcast.spi.hotrestart.backup.HotRestartBackupSerializerHook
com.hazelcast.spi.hotrestart.backup.HotRestartBackupTransactionLogRecord

com.hazelcast.spi.hotrestart.cluster.AbstractMetadataReader
com.hazelcast.spi.hotrestart.cluster.AbstractMetadataWriter
com.hazelcast.spi.hotrestart.cluster.AskForClusterStartResultOperation
com.hazelcast.spi.hotrestart.cluster.AskForExpectedMembersOperation
com.hazelcast.spi.hotrestart.cluster.ClusterHotRestartEventListener
com.hazelcast.spi.hotrestart.cluster.ClusterHotRestartStatusDTOUtil
com.hazelcast.spi.hotrestart.cluster.ClusterMetadataManager
com.hazelcast.spi.hotrestart.cluster.ClusterMetadataWriterLoop
com.hazelcast.spi.hotrestart.cluster.ClusterStateReader
com.hazelcast.spi.hotrestart.cluster.ClusterStateWriter
com.hazelcast.spi.hotrestart.cluster.ClusterVersionReader
com.hazelcast.spi.hotrestart.cluster.ClusterVersionWriter
com.hazelcast.spi.hotrestart.cluster.HotRestartClusterSerializerHook
com.hazelcast.spi.hotrestart.cluster.HotRestartClusterStartStatus
com.hazelcast.spi.hotrestart.cluster.LocalMemberReader
com.hazelcast.spi.hotrestart.cluster.MemberClusterStartInfo
com.hazelcast.spi.hotrestart.cluster.MemberListReader
com.hazelcast.spi.hotrestart.cluster.MemberListWriter
com.hazelcast.spi.hotrestart.cluster.package-info
com.hazelcast.spi.hotrestart.cluster.PartitionTableReader
com.hazelcast.spi.hotrestart.cluster.PartitionTableWriter
com.hazelcast.spi.hotrestart.cluster.PartitionThreadCountReader
com.hazelcast.spi.hotrestart.cluster.PartitionThreadCountWriter
com.hazelcast.spi.hotrestart.cluster.SendClusterStartResultOperation
com.hazelcast.spi.hotrestart.cluster.SendExcludedMemberUuidsOperation
com.hazelcast.spi.hotrestart.cluster.SendExpectedMembersOperation
com.hazelcast.spi.hotrestart.cluster.SendMemberClusterStartInfoOperation
com.hazelcast.spi.hotrestart.cluster.TriggerForceStartOnMasterOperation

com.hazelcast.spi.hotrestart.memory.HotRestartPoolingMemoryManager
com.hazelcast.spi.hotrestart.memory.HotRestartThreadLocalPoolingMemoryManager

com.hazelcast.spi.hotrestart.ConfigDescriptor
com.hazelcast.spi.hotrestart.ForceStartException
com.hazelcast.spi.hotrestart.HotBackupService
com.hazelcast.spi.hotrestart.HotRestartIntegrationService
com.hazelcast.spi.hotrestart.LoadedConfigurationListener
com.hazelcast.spi.hotrestart.PersistentConfigDescriptors
com.hazelcast.spi.hotrestart.RamStoreHelper

com.hazelcast.spi.hotrestart.impl.di.DiContainer
com.hazelcast.spi.hotrestart.impl.di.DiException
com.hazelcast.spi.hotrestart.impl.di.Initialize
com.hazelcast.spi.hotrestart.impl.di.Inject
com.hazelcast.spi.hotrestart.impl.di.Name

com.hazelcast.spi.hotrestart.impl.gc.chunk.ActiveChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.ActiveValChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.Chunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.EmptyLongSet
com.hazelcast.spi.hotrestart.impl.gc.chunk.GrowingChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.StableChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.StableTombChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.StableValChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.SurvivorValChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.WriteThroughChunk
com.hazelcast.spi.hotrestart.impl.gc.chunk.WriteThroughTombChunk

com.hazelcast.spi.hotrestart.impl.gc.mem.MmapMalloc
com.hazelcast.spi.hotrestart.impl.gc.mem.MmapSlab

com.hazelcast.spi.hotrestart.impl.gc.record.Record
com.hazelcast.spi.hotrestart.impl.gc.record.RecordDataHolder
com.hazelcast.spi.hotrestart.impl.gc.record.RecordMap
com.hazelcast.spi.hotrestart.impl.gc.record.RecordMapOffHeap
com.hazelcast.spi.hotrestart.impl.gc.record.RecordMapOnHeap
com.hazelcast.spi.hotrestart.impl.gc.record.RecordOffHeap
com.hazelcast.spi.hotrestart.impl.gc.record.RecordOnHeap
com.hazelcast.spi.hotrestart.impl.gc.record.SetOfKeyHandleOffHeap
com.hazelcast.spi.hotrestart.impl.gc.record.SetOfKeyHandleOnHeap
com.hazelcast.spi.hotrestart.impl.gc.record.SortedBySeqRecordCursorOffHeap
com.hazelcast.spi.hotrestart.impl.gc.record.SortedBySeqRecordCursorOnHeap

com.hazelcast.spi.hotrestart.impl.gc.tracker.Tracker
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerMap
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerMapBase
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerMapOffHeap
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerMapOnHeap
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerOffHeap
com.hazelcast.spi.hotrestart.impl.gc.tracker.TrackerOnHeap

com.hazelcast.spi.hotrestart.impl.gc.BackupExecutor
com.hazelcast.spi.hotrestart.impl.gc.BackupTask
com.hazelcast.spi.hotrestart.impl.gc.ChunkManager
com.hazelcast.spi.hotrestart.impl.gc.ChunkPriorityQueue
com.hazelcast.spi.hotrestart.impl.gc.GcExecutor
com.hazelcast.spi.hotrestart.impl.gc.GcHelper
com.hazelcast.spi.hotrestart.impl.gc.GcLogger
com.hazelcast.spi.hotrestart.impl.gc.GcMainLoop
com.hazelcast.spi.hotrestart.impl.gc.GcParams
com.hazelcast.spi.hotrestart.impl.gc.MutatorCatchup
com.hazelcast.spi.hotrestart.impl.gc.package-info
com.hazelcast.spi.hotrestart.impl.gc.PrefixTombstoneManager
com.hazelcast.spi.hotrestart.impl.gc.Rebuilder
com.hazelcast.spi.hotrestart.impl.gc.Snapshotter
com.hazelcast.spi.hotrestart.impl.gc.TombChunkSelector
com.hazelcast.spi.hotrestart.impl.gc.TombEvacuator
com.hazelcast.spi.hotrestart.impl.gc.ValChunkSelector
com.hazelcast.spi.hotrestart.impl.gc.ValEvacuator

com.hazelcast.spi.hotrestart.impl.io.ChunkFileCursor
com.hazelcast.spi.hotrestart.impl.io.ChunkFileOut
com.hazelcast.spi.hotrestart.impl.io.ChunkFileRecord
com.hazelcast.spi.hotrestart.impl.io.ChunkFilesetCursor
com.hazelcast.spi.hotrestart.impl.io.DefaultCopyStrategy
com.hazelcast.spi.hotrestart.impl.io.FileCopyStrategy
com.hazelcast.spi.hotrestart.impl.io.HardLinkCopyStrategy
com.hazelcast.spi.hotrestart.impl.io.TombFileAccessor

com.hazelcast.spi.hotrestart.impl.ConcurrentHotRestartStore
com.hazelcast.spi.hotrestart.impl.HotRestarter
com.hazelcast.spi.hotrestart.impl.HotRestartModule
com.hazelcast.spi.hotrestart.impl.HotRestartPersistenceEngine
com.hazelcast.spi.hotrestart.impl.HotRestartStoreConfig
com.hazelcast.spi.hotrestart.impl.KeyOffHeap
com.hazelcast.spi.hotrestart.impl.KeyOnHeap
com.hazelcast.spi.hotrestart.impl.package-info
com.hazelcast.spi.hotrestart.impl.RamStoreRestartLoop
com.hazelcast.spi.hotrestart.impl.RestartItem
com.hazelcast.spi.hotrestart.impl.RunnableWithStatus
com.hazelcast.spi.hotrestart.impl.SetOfKeyHandle
com.hazelcast.spi.hotrestart.impl.SimpleHandleOffHeap
com.hazelcast.spi.hotrestart.impl.SortedBySeqRecordCursor

com.hazelcast.spi.hotrestart.HotRestartException
com.hazelcast.spi.hotrestart.HotRestartKey
com.hazelcast.spi.hotrestart.HotRestartStore
com.hazelcast.spi.hotrestart.KeyHandle
com.hazelcast.spi.hotrestart.KeyHandleOffHeap
com.hazelcast.spi.hotrestart.RamStore
com.hazelcast.spi.hotrestart.RamStoreRegistry
com.hazelcast.spi.hotrestart.RecordDataSink
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-private-api-cleanup-4 branch from 9079be0 to c48c530 Sep 26, 2019
@mmedenjak mmedenjak merged commit 383d6e6 into hazelcast:master Sep 29, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak mmedenjak deleted the mmedenjak:4.0-private-api-cleanup-4 branch Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.