Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connection attempt limit and period configs #15675

Conversation

@sancar
Copy link
Member

sancar commented Oct 4, 2019

They are removed in favor of ConnectionRetryConfig.
ConnectionRetryConfig enabled is also removed. It is enabled always.

Attempt limit and period configurations in tests changed with appropriate ConnectionRetryConfig configs.

EE counterpart hazelcast/hazelcast-enterprise#3206

@sancar sancar requested a review from hazelcast/clients as a code owner Oct 4, 2019
@sancar sancar self-assigned this Oct 4, 2019
@sancar sancar added this to the 4.0 milestone Oct 4, 2019
@sancar sancar force-pushed the sancar:cleanup/removeDeprecatedConnectionConfigs/master branch from 4a65cac to 6dc3591 Oct 4, 2019
@sancar sancar force-pushed the sancar:cleanup/removeDeprecatedConnectionConfigs/master branch 2 times, most recently from 1a5325b to e3f52ee Oct 4, 2019
They are removed in favor of ConnectionRetryConfig.
ConnectionRetryConfig enabled is also removed. It is enabled always.
@sancar sancar force-pushed the sancar:cleanup/removeDeprecatedConnectionConfigs/master branch from e3f52ee to c14b163 Oct 4, 2019
@mmedenjak mmedenjak merged commit 342ea90 into hazelcast:master Oct 4, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@sancar sancar deleted the sancar:cleanup/removeDeprecatedConnectionConfigs/master branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.