Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WanPublisherState to wan package from config #15791

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@blazember
Copy link
Contributor

blazember commented Oct 16, 2019

Moving WanPublisherState from com.hazelcast.config to
com.hazelcast.wan. The enum is used to configure initial publisher
state of WanBatchReplicationPublisherConfig. Besides that, the same
enum is used internally the WAN implementation and on
LocalWanPublisherStats too, therefore it fits better in the wan
package than in config.

EE PR: hazelcast/hazelcast-enterprise#3243

Moving `WanPublisherState` from `com.hazelcast.config` to
`com.hazelcast.wan`. The enum is used to configure initial publisher
state of `WanBatchReplicationPublisherConfig`. Besides that, the same
enum is used internally the WAN implementation and on
`LocalWanPublisherStats` too, therefore it fits better in the wan
package than in config.
@blazember blazember added this to the 4.0 milestone Oct 16, 2019
@blazember blazember requested a review from mmedenjak Oct 16, 2019
@blazember blazember self-assigned this Oct 16, 2019
@blazember

This comment has been minimized.

Copy link
Contributor Author

blazember commented Oct 16, 2019

run-lab-run

@blazember

This comment has been minimized.

Copy link
Contributor Author

blazember commented Oct 17, 2019

Thanks for the review guys 👍

@blazember blazember merged commit eec1871 into hazelcast:master Oct 17, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@blazember blazember deleted the blazember:4.0/move-wan-publisher-state branch Oct 17, 2019
alex-dukhno added a commit to alex-dukhno/hazelcast that referenced this pull request Oct 18, 2019
Moving `WanPublisherState` from `com.hazelcast.config` to
`com.hazelcast.wan`. The enum is used to configure initial publisher
state of `WanBatchReplicationPublisherConfig`. Besides that, the same
enum is used internally the WAN implementation and on
`LocalWanPublisherStats` too, therefore it fits better in the wan
package than in config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.