Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CPSubsystemManagementService.restart() to .reset() #15798

Merged

Conversation

@metanet
Copy link
Contributor

metanet commented Oct 17, 2019

We have CPSubsystemManagementService.restart() to wipe-out and reset
the whole CP Subsystem in case of permanent loss of majority. After CP
Subsystem Persistence work is done, it turned out that .restart() is a
bad choice for this functionality because it creates confusion with
restarting CP members by using persistence. This PR renames this method
to .reset() to eliminate this confusion.

EE PR: hazelcast/hazelcast-enterprise#3249
Ref Manual PR: hazelcast/hazelcast-reference-manual#735

@metanet metanet added this to the 4.0 milestone Oct 17, 2019
@metanet metanet requested a review from mdogan Oct 17, 2019
@metanet metanet requested a review from hazelcast/clients as a code owner Oct 17, 2019
@mdogan
mdogan approved these changes Oct 17, 2019
Copy link
Member

mdogan left a comment

Reference-manual should be updated too.

@metanet metanet force-pushed the metanet:improvement/master/cp-subsystem/reset branch from 35d3e57 to e136188 Oct 17, 2019
metanet added a commit to metanet/hazelcast-reference-manual that referenced this pull request Oct 17, 2019
@sancar
sancar approved these changes Oct 17, 2019
@metanet

This comment has been minimized.

Copy link
Contributor Author

metanet commented Oct 17, 2019

run-lab-run

We have CPSubsystemManagementService.restart() to wipe-out and reset
the whole CP Subsystem in case of permanent loss of majority. After CP
Subsystem Persistence work is done, it turned out that .restart() is a
bad choice for this functionality because it creates confusion with
restarting CP members by using persistence. This PR renames this method
to .reset() to eliminate this confusion.
@metanet metanet force-pushed the metanet:improvement/master/cp-subsystem/reset branch from e136188 to 7d8893e Oct 17, 2019
@metanet metanet merged commit 00d5594 into hazelcast:master Oct 18, 2019
1 check passed
1 check passed
default Test PASSed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.