Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Counters so that they can be reused in Jet #15867

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@jbartok
Copy link
Member

jbartok commented Oct 25, 2019

We found ourselves re-implementing these counters in Jet and we would prefer to just use them. For that we need them to also have a set method. This PR adds that.

@jbartok jbartok requested review from pveentjer and mmedenjak Oct 25, 2019
@jbartok jbartok changed the title Enhance `Counter`s so that they can be reused in Jet Enhance Counters so that they can be reused in Jet Oct 25, 2019
@mmedenjak mmedenjak added this to the 4.0 milestone Oct 25, 2019
@mmedenjak mmedenjak requested a review from cangencer Oct 30, 2019
@mmedenjak mmedenjak merged commit 71c012f into hazelcast:master Oct 31, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak mmedenjak removed the request for review from pveentjer Oct 31, 2019
@mdogan

This comment has been minimized.

Copy link
Member

mdogan commented Oct 31, 2019

Added as a commit to my EE PR: hazelcast/hazelcast-enterprise@325e397

@jbartok jbartok deleted the jbartok:enhance-counters branch Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.