Collect tcp.connection metrics only once #15885
Merged
+63
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `TcpIpUnifiedEndpointManager` and `TcpIpEndpointManager` provided dynamic metrics while the first extends the latter. This results in double metrics collection. This issue is solved by making `TcpIpUnifiedEndpointManager` not providing dynamic metrics since those are already provided by its parent. Fixes hazelcast#15883
petrpleshachkov
approved these changes
Oct 28, 2019
vojtechtoman
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
TcpIpUnifiedEndpointManagerandTcpIpEndpointManagerprovideddynamic metrics while the first extends the latter. This results in
double metrics collection. This issue is solved by making
TcpIpUnifiedEndpointManagernot providing dynamic metrics since thoseare already provided by its parent.
Fixes #15883