Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config, partition and other private classes to internal API #15887

Merged
merged 3 commits into from Oct 30, 2019

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented Oct 28, 2019

Probably the last big PR to clean up private API. As before, there was no code change, except for package/import changes and checkstyle cleanup. Each requested reviewer can review their part.

@blazember
com.hazelcast.client.config.AbstractQueryCacheConfigBuilderHelper
com.hazelcast.client.config.ClientAliasedDiscoveryConfigUtils
com.hazelcast.client.config.ClientConfigSections
com.hazelcast.client.config.ClientDomConfigProcessor
com.hazelcast.client.config.ClientFailoverConfigSections
com.hazelcast.client.config.ClientFailoverDomConfigProcessor
com.hazelcast.client.config.QueryCacheConfigBuilderHelper
com.hazelcast.client.config.QueryCacheXmlConfigBuilderHelper
com.hazelcast.client.config.QueryCacheYamlConfigBuilderHelper
com.hazelcast.client.config.XmlClientConfigLocator
com.hazelcast.client.config.XmlClientFailoverConfigLocator
com.hazelcast.client.config.YamlClientConfigLocator
com.hazelcast.client.config.YamlClientDomConfigProcessor
com.hazelcast.client.config.YamlClientFailoverConfigLocator
com.hazelcast.client.config.YamlClientFailoverDomConfigProcessor

@blazember
com.hazelcast.config.AbstractBasicConfig
com.hazelcast.config.AbstractConfigLocator
com.hazelcast.config.AbstractDomConfigProcessor
com.hazelcast.config.AbstractDomVariableReplacer
com.hazelcast.config.AbstractYamlConfigBuilder
com.hazelcast.config.AliasedDiscoveryConfigUtils
com.hazelcast.config.ConfigDataSerializerHook
com.hazelcast.config.ConfigLoader
com.hazelcast.config.ConfigReplacerHelper
com.hazelcast.config.ConfigSections
com.hazelcast.config.DomConfigHelper
com.hazelcast.config.DomConfigProcessor
com.hazelcast.config.DomVariableReplacer
com.hazelcast.config.MemberDomConfigProcessor
com.hazelcast.config.XmlConfigLocator
com.hazelcast.config.XmlDomVariableReplacer
com.hazelcast.config.YamlConfigLocator
com.hazelcast.config.YamlDomVariableReplacer
com.hazelcast.config.YamlMemberDomConfigProcessor

@mdogan
com.hazelcast.spi.partition.FragmentedMigrationAwareService
com.hazelcast.spi.partition.IPartition
com.hazelcast.spi.partition.IPartitionLostEvent
com.hazelcast.spi.partition.IPartitionService
com.hazelcast.spi.partition.MigrationAwareService
com.hazelcast.spi.partition.MigrationEndpoint
com.hazelcast.spi.partition.PartitionAwareService
com.hazelcast.spi.partition.PartitionMigrationEvent
com.hazelcast.spi.partition.PartitionReplicationEvent

com.hazelcast.map.journal.EventJournalMapEvent

@taburet
com.hazelcast.query.extractor.ArgumentParser

EE: hazelcast/hazelcast-enterprise#3290

@mmedenjak mmedenjak added this to the 4.0 milestone Oct 28, 2019
@mmedenjak mmedenjak requested review from mdogan, taburet and blazember Oct 28, 2019
@mmedenjak mmedenjak requested a review from hazelcast/clients as a code owner Oct 28, 2019
@mmedenjak mmedenjak self-assigned this Oct 28, 2019
Matko Medenjak added 2 commits Oct 28, 2019
com.hazelcast.client.config.AbstractQueryCacheConfigBuilderHelper
com.hazelcast.client.config.ClientAliasedDiscoveryConfigUtils
com.hazelcast.client.config.ClientConfigSections
com.hazelcast.client.config.ClientDomConfigProcessor
com.hazelcast.client.config.ClientFailoverConfigSections
com.hazelcast.client.config.ClientFailoverDomConfigProcessor
com.hazelcast.client.config.QueryCacheConfigBuilderHelper
com.hazelcast.client.config.QueryCacheXmlConfigBuilderHelper
com.hazelcast.client.config.QueryCacheYamlConfigBuilderHelper
com.hazelcast.client.config.XmlClientConfigLocator
com.hazelcast.client.config.XmlClientFailoverConfigLocator
com.hazelcast.client.config.YamlClientConfigLocator
com.hazelcast.client.config.YamlClientDomConfigProcessor
com.hazelcast.client.config.YamlClientFailoverConfigLocator
com.hazelcast.client.config.YamlClientFailoverDomConfigProcessor

com.hazelcast.config.AbstractBasicConfig
com.hazelcast.config.AbstractConfigLocator
com.hazelcast.config.AbstractDomConfigProcessor
com.hazelcast.config.AbstractDomVariableReplacer
com.hazelcast.config.AbstractYamlConfigBuilder
com.hazelcast.config.AliasedDiscoveryConfigUtils
com.hazelcast.config.ConfigDataSerializerHook
com.hazelcast.config.ConfigLoader
com.hazelcast.config.ConfigReplacerHelper
com.hazelcast.config.ConfigSections
com.hazelcast.config.DomConfigHelper
com.hazelcast.config.DomConfigProcessor
com.hazelcast.config.DomVariableReplacer
com.hazelcast.config.MemberDomConfigProcessor
com.hazelcast.config.XmlConfigLocator
com.hazelcast.config.XmlDomVariableReplacer
com.hazelcast.config.YamlConfigLocator
com.hazelcast.config.YamlDomVariableReplacer
com.hazelcast.config.YamlMemberDomConfigProcessor

com.hazelcast.spi.partition.FragmentedMigrationAwareService
com.hazelcast.spi.partition.IPartition
com.hazelcast.spi.partition.IPartitionLostEvent
com.hazelcast.spi.partition.IPartitionService
com.hazelcast.spi.partition.MigrationAwareService
com.hazelcast.spi.partition.MigrationEndpoint
com.hazelcast.spi.partition.PartitionAwareService
com.hazelcast.spi.partition.PartitionMigrationEvent
com.hazelcast.spi.partition.PartitionReplicationEvent

com.hazelcast.map.journal.EventJournalMapEvent

com.hazelcast.query.extractor.ArgumentParser
Matko Medenjak
@mmedenjak mmedenjak force-pushed the mmedenjak:4.0-private-api-cleanup-7 branch from e784036 to 9e179d3 Oct 28, 2019
Copy link
Contributor

taburet left a comment

ArgumentParser part looks good. Probably we can even remove it completely, there is no extension points currently to customize it.

@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Oct 29, 2019

@blazember reverted AbstractYamlConfigBuilder back to com.hazelcast.config
@taburet true, for now I just wanted to move it since it's definitely not public. We can remove it in any other minor release now.

@sancar
sancar approved these changes Oct 30, 2019
@mdogan
mdogan approved these changes Oct 30, 2019
@mmedenjak mmedenjak merged commit 55765cc into hazelcast:master Oct 30, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak mmedenjak deleted the mmedenjak:4.0-private-api-cleanup-7 branch Oct 30, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Oct 30, 2019

Thank you for the quick reviews, guys! I know I'm getting annoying with this package cleanup :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.