Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EventJournalCacheEvent and EventJournalMapEvent back to public API #15900

Merged
merged 2 commits into from Oct 31, 2019

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented Oct 30, 2019

They are exposed as public API in jet.

They are exposed as public API in jet.
@mmedenjak mmedenjak added this to the 4.0 milestone Oct 30, 2019
@mmedenjak mmedenjak requested review from mtopolnik and cangencer Oct 30, 2019
@mmedenjak mmedenjak requested a review from hazelcast/clients as a code owner Oct 30, 2019
@mmedenjak mmedenjak self-assigned this Oct 30, 2019
Copy link
Contributor

cangencer left a comment

Approved. It would also be ok to have those in com.hazelcast.map since it seems com.hazelcast.map.journal has only a single file.

@mmedenjak mmedenjak removed the request for review from mtopolnik Oct 30, 2019
@sancar
sancar approved these changes Oct 31, 2019
@mmedenjak mmedenjak merged commit b5623ff into hazelcast:master Oct 31, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak mmedenjak deleted the mmedenjak:4.0-private-api-cleanup-9 branch Oct 31, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Oct 31, 2019

Thank you for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.