Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overriding operation metrics #15910

Merged

Conversation

@blazember
Copy link
Contributor

blazember commented Oct 31, 2019

Starting HZ member in 4.0-BETA-1 logs Overwriting existing probe
extensively, referring to operation.* metrics. This happens because
the operation metrics don't distinguish based on the partition/generic
id. This is fixed by adding partitionId and genericId tags as "id tags".

This fix is needed only for the 4.0-BETA-1, on master it will be fixed
differently.

Starting HZ member in 4.0-BETA-1 logs `Overwriting existing probe`
extensively, referring to `operation.*` metrics. This happens because
the operation metrics doesn't distinguish based on the partition/generic
id. This is fixed by adding `partitionId` and `genericId` tags as "id
tags".
@blazember blazember added this to the 4.0 milestone Oct 31, 2019
@blazember blazember self-assigned this Oct 31, 2019
@blazember

This comment has been minimized.

Copy link
Contributor Author

blazember commented Oct 31, 2019

Merging with an unrelated EntryLoaderClientSimpleTest.testLoadAllWithExpirationTimes[inMemoryFormat: BINARY] test failure caused by big hiccups.

@blazember blazember merged commit 5d54b6c into hazelcast:4.0-BETA-1 Oct 31, 2019
1 check failed
1 check failed
default Test `FAIL`ed. http://jenkins.hazelcast.com/job/Hazelcast-pr-builder/4078/
Details
@blazember blazember deleted the blazember:4.0-BETA-1/fix-operation-metrics branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.