Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move login modules from impl to loginimpl package #15929

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@kwart
Copy link
Contributor

kwart commented Nov 4, 2019

OS part of the hazelcast/hazelcast-enterprise#3319

Login modules in Hazelcast EE are semi-internal, we should have them documented in the generated JavaDoc. Therefore I would like to move them from impl package to a new one - loginimpl.

@kwart kwart added this to the 4.0 milestone Nov 4, 2019
@kwart kwart requested review from tkountis and mmedenjak Nov 4, 2019
@kwart kwart self-assigned this Nov 4, 2019
@tkountis

This comment has been minimized.

Copy link
Contributor

tkountis commented Nov 5, 2019

Approved, but curious whether an SPI would more appropriate than marking the package as public (or semi-internal).

@kwart kwart force-pushed the kwart:login-modules-javadoc branch from ebab327 to 40e5c28 Nov 8, 2019
@kwart

This comment has been minimized.

Copy link
Contributor Author

kwart commented Nov 8, 2019

Thanks for reviews, guys.

Approved, but curious whether an SPI would more appropriate than marking the package as public (or semi-internal).

The *.spi package would suggest that we are defining the SPI, what we are not. We implement the existing login module SPI. So a better possibility would be *.spi.impl, but it doesn't solve my problem as it hides the classes from the javadoc. Then the last option is something like spiimpl, which I feel is close to the change introduced by this PR. And I like the *.loginimpl more, as it feels more descriptive to me.

@kwart kwart merged commit ec9b932 into hazelcast:master Nov 8, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@kwart kwart deleted the kwart:login-modules-javadoc branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.