Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Make gathering multimap stats not to break last access merge policy #16003

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@blazember
Copy link
Contributor

blazember commented Nov 13, 2019

Gathering multimap statistics calls MultiMapPartitionContainer#getMultiMapContainer() that updates the lastAccessTime of the returned container, which in the end breaks the last access merge policy. This is fixed by making gathering statistics not to count access. Also, retrieving the container on backups for the given partition made not to be considered access.

Fixes #16001

4.0 PR: #16004

Gathering multimap statistics calls
MultiMapPartitionContainer#getMultiMapContainer() that updates the
lastAccessTime of the returned container, which in the end breaks the
last access merge policy. This is fixed by making gathering statistics
not to count an access. Also, retrieving the container on backups
for the given partition made not to be considered an access.

Fixes #16001
@blazember blazember added this to the 3.12.5 milestone Nov 13, 2019
@blazember blazember self-assigned this Nov 13, 2019
@blazember blazember changed the title Make gathering multimap stats not to break last access merge policy [3.x] Make gathering multimap stats not to break last access merge policy Nov 13, 2019
@blazember blazember merged commit c0137b9 into hazelcast:maintenance-3.x Nov 13, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@blazember blazember deleted the blazember:3.x/fix/gh-16001 branch Nov 13, 2019
blazember added a commit to blazember/hazelcast that referenced this pull request Nov 15, 2019
Follow-up on hazelcast#16003 that fixed hazelcast#16001 by introducing a second parameter
to `MultiMapPartitionContainer#getMultiMapContainer(String,boolean)` to
indicate whether or not the container should be `access()`'ed. This
broke `AnswerTest` and that can't be fixed easily since there is no such
method in HZ 3.11. This is fixed by making the aforementioned method
private and adding back the previously existing
`getMultiMapContainer(String name)` and introducing
`getMultiMapContainerWithoutAccess(String name)` that delegate to the
private `getMultiMapContainer(String,boolean)`.

Fixes hazelcast#16011
blazember added a commit that referenced this pull request Nov 15, 2019
Follow-up on #16003 that fixed #16001 by introducing a second parameter
to MultiMapPartitionContainer#getMultiMapContainer(String,boolean) to
indicate whether or not the container should be access()'ed. This broke
AnswerTest that can't be fixed easily since
getMultiMapContainer(String,boolean) doesn't exist in HZ 3.11. Therefore,
the test is fixed by making the aforementioned method private and adding
back the previously existing getMultiMapContainer(String name) while
introducing getMultiMapContainerWithoutAccess(String name) that
delegate to the private getMultiMapContainer(String,boolean).

Fixes #16011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.