Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC: Add special client type for Java client used by MC #16006

Merged

Conversation

@puzpuzpuz
Copy link
Contributor

puzpuzpuz commented Nov 13, 2019

  • Introduces a special connection type for MC client purposes.
  • Based on this special connection type, implements MC client exclusion from client B/W filtering (as discussed in #15942). This exclusion is encapsulated in ClientEngineImpl.
  • Doesn't change anything in client type detection on the client side, so MC client will "consider" itself a normal Java client (e.g. ClientImpl#getClientType returns JVM and so on). Since MC client won't be sending stats, it should be fine to leave it as is.

Depends on #15942

puzpuzpuz added 2 commits Nov 15, 2019
…new-type-for-mc-client
…new-type-for-mc-client
@puzpuzpuz puzpuzpuz marked this pull request as ready for review Nov 18, 2019
@puzpuzpuz puzpuzpuz requested a review from hazelcast/clients as a code owner Nov 18, 2019
@puzpuzpuz puzpuzpuz requested a review from emre-aydin Nov 18, 2019
@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Nov 21, 2019

run-lab-run

@puzpuzpuz puzpuzpuz force-pushed the puzpuzpuz:v4.0/enhancement/new-type-for-mc-client branch from c8016ef to 2dd14a0 Nov 21, 2019
puzpuzpuz added 3 commits Nov 21, 2019
@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Nov 21, 2019

@emre-aydin as I had to change the implementation due to merging with #16030, could you take another look at the PR?

@sancar
sancar approved these changes Nov 21, 2019
@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Nov 21, 2019

@ihsandemir could you take another look at the PR?

@puzpuzpuz puzpuzpuz requested a review from ihsandemir Nov 21, 2019
@puzpuzpuz

This comment has been minimized.

Copy link
Contributor Author

puzpuzpuz commented Nov 22, 2019

Thanks for the review @ihsandemir! Your comments were very helpful.

@puzpuzpuz puzpuzpuz merged commit 8603354 into hazelcast:master Nov 22, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@puzpuzpuz puzpuzpuz deleted the puzpuzpuz:v4.0/enhancement/new-type-for-mc-client branch Nov 22, 2019
petrpleshachkov pushed a commit to petrpleshachkov/hazelcast that referenced this pull request Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.