Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapts configuration exceptions as required by JSR-107 spec #16007

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@vbekiaris
Copy link
Contributor

vbekiaris commented Nov 13, 2019

As specified in CacheManager#createCache javadoc, in case an invalid
configuration is supplied, an IllegalArgumentException should be thrown.
This change applies also to validation in the context of
CacheManager#getCache and HazelcastInstance#getCacheManager#getCache
methods, so that a uniform approach across all get-or-create cache
methods is applied.

Fixes hazelcast/hazelcast-enterprise#3229 (comment)

@vbekiaris vbekiaris added this to the 4.0 milestone Nov 13, 2019
@vbekiaris vbekiaris requested a review from ahmetmircik Nov 13, 2019
@vbekiaris vbekiaris self-assigned this Nov 13, 2019
@vbekiaris vbekiaris force-pushed the vbekiaris:fixes/4.0/cacheconfig-jsr branch from 13a2044 to a17e0e0 Nov 13, 2019
@Holmistr

This comment has been minimized.

Copy link
Collaborator

Holmistr commented Nov 13, 2019

run-lab-run

As specified in CacheManager#createCache javadoc, in case an invalid
configuration is supplied, an IllegalArgumentException should be thrown.
This change applies also to validation in the context of
CacheManager#getCache and HazelcastInstance#getCacheManager#getCache
methods, so that a uniform approach across all get-or-create cache
methods is applied.
@vbekiaris vbekiaris force-pushed the vbekiaris:fixes/4.0/cacheconfig-jsr branch from a17e0e0 to 358f763 Nov 14, 2019
@mmedenjak mmedenjak self-requested a review Nov 15, 2019
@vbekiaris vbekiaris merged commit 049708f into hazelcast:master Nov 15, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@vbekiaris vbekiaris deleted the vbekiaris:fixes/4.0/cacheconfig-jsr branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.