Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow free client type names. #16030

Merged
merged 4 commits into from Nov 21, 2019

Conversation

@sancar
Copy link
Member

sancar commented Nov 15, 2019

fixes #16012

@sancar sancar added this to the 4.0 milestone Nov 15, 2019
@sancar sancar self-assigned this Nov 15, 2019
@sancar sancar force-pushed the sancar:cleanup/client_connectionType/master branch 2 times, most recently from b0452b6 to a7d1936 Nov 18, 2019
@sancar sancar marked this pull request as ready for review Nov 18, 2019
@sancar sancar requested a review from hazelcast/clients as a code owner Nov 18, 2019
@sancar sancar force-pushed the sancar:cleanup/client_connectionType/master branch from a7d1936 to d1f8741 Nov 18, 2019
@sancar

This comment has been minimized.

Copy link
Member Author

sancar commented Nov 19, 2019

run-lab-run

@puzpuzpuz puzpuzpuz self-requested a review Nov 19, 2019
@@ -46,11 +46,12 @@
InetSocketAddress getSocketAddress();

/**
* Returns the type of this client.
* Type could be a client type from {@link com.hazelcast.internal.nio.ConnectionType} or
* it can be a custom client implementation with a name outside of this @{link ConnectionType}

This comment has been minimized.

Copy link
@puzpuzpuz

puzpuzpuz Nov 20, 2019

Contributor

Misprint at the end of this line: should be {@link instead of @{link

@@ -104,6 +103,11 @@ public String getConnectionType() {
return connectionType;
}

@Probe

This comment has been minimized.

Copy link
@blazember

blazember Nov 20, 2019

Contributor

I think we need @Probe("connectionType") here. Just to be clear in the log.

@sancar sancar force-pushed the sancar:cleanup/client_connectionType/master branch from 7c1598d to c60e7d9 Nov 21, 2019
@puzpuzpuz puzpuzpuz self-requested a review Nov 21, 2019
@sancar

This comment has been minimized.

Copy link
Member Author

sancar commented Nov 21, 2019

run-lab-run

@sancar sancar merged commit 8994d1d into hazelcast:master Nov 21, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@sancar sancar deleted the sancar:cleanup/client_connectionType/master branch Nov 21, 2019
petrpleshachkov pushed a commit to petrpleshachkov/hazelcast that referenced this pull request Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.