Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against null TestHazelcastInstanceFactory#registry #16033

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@vbekiaris
Copy link
Contributor

vbekiaris commented Nov 15, 2019

TestHazelcastInstanceFactory#registry can be null when using real
network. Some usages of this field were not checking for null value
and could result in NullPointerException being thrown.

TestHazelcastInstanceFactory#registry can be null when using real
network. Some usages of this field were not checking for null value
and could result in NullPointerException being thrown.
@vbekiaris vbekiaris added this to the 4.0 milestone Nov 15, 2019
@vbekiaris vbekiaris self-assigned this Nov 15, 2019
@vbekiaris vbekiaris merged commit f39e27f into hazelcast:master Nov 15, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@vbekiaris

This comment has been minimized.

Copy link
Contributor Author

vbekiaris commented Nov 15, 2019

@petrpleshachkov @ahmetmircik thanks for the reviews!

@vbekiaris vbekiaris deleted the vbekiaris:fixes/4.0/testhzfactory-npe branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.